Repository navigation
Bump itsjustanks/daemon to v0.13.0 - #156
github-actions[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Needs from you: nothing, changes requested
@itsjustanks, Hosts v0.13.0 can't merge yet: the repository has no OVERVIEW.md at the tagged commit, and the registry needs one for every new version.
Change needed: add OVERVIEW.md next to paseo-plugin.json, tag a new release, and the bump workflow opens a fresh pull request for it. Your file replaces the registry copy plugins/itsjustanks/daemon.md. You can start from that copy without its last "imported from paseo.cafe" line, but v0.13.0 changes what it describes, so the new file needs to cover:
- Restart for a stuck plugin: after you confirm, it runs
paseo plugin reload <id>, and if that hangs it stops that plugin's process with SIGTERM, then SIGKILL. The registry copy says the Processes tab refuses to stop Paseo components. - The optional automatic stop of the biggest runaway process under sustained memory pressure, off by default. The registry copy says health checks never start a stop.
- What it reads to do this: Paseo's
daemon.logunder the Paseo home, checked every 10 seconds (30 on macOS) while the plugin runs, and memory pressure from the system.
The shape is in REVIEW.md: what it is and does, how it works if needed, setup, then what it reads, sends, and runs and known limits. Leave out installation steps, badges, changelog, and license sections.
The code change in v0.13.0 is fine. Nothing else needs to change.
Review data
- Artifact: git
https://github.com/itsjustanks/paseo-plugin-daemon.git,59b315d064c7d873cade37bf523c6351a4da20ca(tagv0.13.0), from3621929c1fb04118b6d033245448eb1c7f2bfac9(tagv0.12.1). NopluginPath. - Pin: both commits exist on the remote, and both tags peel to them.
paseo-plugin.jsonis at the root. - Validation:
npm testpasses (140/140).node scripts/validate.ts --online --changedfails with one error:itsjustanks/daemon/OVERVIEW.md is required. - Extracted and inspected: both commits exported and diffed locally, 41 files changed and 12 added. New
server/daemon-log.ts(parses plugin timeouts and Loading/Ready lines from the daemon log),server/plugin-procs.ts(matches a plugin's process by start time),server/plugin-restart.ts(reload, then escalation),server/paseo-cli.ts(runspaseo),server/guard-loop.ts(10-second check loop and the opt-in memory guard),shared/guard.ts,client/guard.tsx.server/processes.tsaddsautoStopBiggest;shared/settings.ts:40addsautoStopRunaways, defaultfalse. - Install-time commands:
paseo-plugin.jsonbuildisnpm ci --ignore-scripts, unchanged. No manifestinstall.package.jsonhas nopreinstall,install,postinstall, orprepare; its scripts are dev-only andscripts/*.mjsis unchanged and not run at install. - Dependencies: runtime
@getpaseo/relay0.7.2 andws8.21.3, unchanged.package-lock.jsonhas 443 entries, eachresolvedon registry.npmjs.org with anintegrity, andnpm ci --ignore-scriptsinstalls it; only the root version field changes. Entries with install scripts (esbuild,fsevents) are dev only and do not run under--ignore-scripts. - Hosts: none added. The existing
trycloudflare.com,relay.paseo.sh, and GitHub releases forcloudflaredare unchanged. - Credentials and environment: one new read,
PASEO_HOMEwith the Paseo home directory as fallback (server/daemon-log.ts:173), to finddaemon.log.server/paseo-cli.ts:20passes the plugin's environment plusNO_COLOR=1topaseo. No credential files, tokens, or keychains. - Filesystem: reads only.
daemon.log(4 MB on the first poll, then at most 1 MB of new data per poll,server/daemon-log.ts:202-212), rotated daemon logs when a restart needs them (at most 6 files and 96 MB,server/daemon-log.ts:250), and memory pressure and same-user process status from/procand cgroups (server/guard-loop.ts:52-78,server/plugin-procs.ts:130). No new writes beyond the plugin's own action log. - Execution:
execFilewith no shell and fixed argument arrays (server/paseo-cli.ts:19-25). The binary is thepaseothat ships next to the daemon, elsepaseoonPATH(server/paseo-cli.ts:33-41). Arguments are--version,plugin reload --help, andplugin reload <id>, where<id>must match^[a-z0-9][a-z0-9._-]{0,63}$(shared/guard.ts:181). Restart refuses its own id (server/plugin-restart.ts:100-101), signals only after the reload times out, and only a direct child of the daemon owned by the same user runningplugin-process.jswhose start time falls in exactly one Loading/Ready window (server/plugin-procs.ts:44-73,112); it re-checks the process before SIGTERM and SIGKILL (server/plugin-restart.ts:147-170). The user confirms each restart in the UI (client/guard.tsx:66-75). The memory guard is off by default and uses the existing signed stop path (server/guard-loop.ts:247-268). Noeval,new Function, or dynamicimport()added. - Runtime installs: none added; the existing
cloudflareddownload still runs only when the user presses its button. - Source match: git artifact; readable TypeScript, no bundled or minified files.
- Listing media: six PNGs pinned to
3621929, each HTTP 200image/png. - Overview: missing at
59b315d. The registry copy contradicts v0.13.0 on stopping Paseo plugin processes and on health checks never stopping anything. - Decision: changes requested, because
OVERVIEW.mdis missing. - Reviewed commit:
a362e69d0c4144419b1a1e47ae8ae0ab50290eea
itsjustanks/daemon: {"kind":"git","remote":"https://github.com/itsjustanks/paseo-plugin-daemon.git","commit":"3621929c1fb04118b6d033245448eb1c7f2bfac9","tag":"v0.12.1"} -> {"kind":"git","remote":"https://github.com/itsjustanks/paseo-plugin-daemon.git","commit":"59b315d064c7d873cade37bf523c6351a4da20ca","tag":"v0.13.0"}Git tag
v0.13.0pins commit59b315d064c7d873cade37bf523c6351a4da20ca.Original submitter is not recorded; refer to the source owner.
Merging approves this version. The published index keeps pointing at the previous one until then.
Artifact diff (truncated; the full diff is in the workflow artifact)
This version has no OVERVIEW.md. The registry requires one to update a listing; the bump cannot merge until the repository adds it.
Inline validation failed. See the Bump workflow log.