Repository navigation
Read plugin manifests and overviews from their pinned artifact - #155
Merged
Merged
Conversation
npm overviews were read from a provenance-linked repository while manifests came from the tarball. Resolve both files through the install pin so package contents do not depend on repository metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm submissions containing OVERVIEW.md failed when their package lacked provenance: the registry looked for the overview in GitHub while reading the manifest from npm. Both files now come from the verified pinned tarball for npm, or the pinned commit and plugin directory for GitHub.
One artifact reader owns source selection and pin verification across submission pinning, validation, publication, and bumps. Missing-file guidance now points authors to the submitted artifact.
Goals:
Non-goals: changing submission authorization, registry records or pins, content review policy, or asset hosting.
Refs #152. This fixes the file-reading failure; the submission still needs its normal review.
Verification:
Compatibility: existing listings passed full validation and publication. npm packages must ship their overview in the tarball; unchanged imported listings retain the existing registry-stopgap policy.