Repository navigation
fix(registry): read manifest metadata and preserve overrides - #154
Merged
Merged
Conversation
Resolve display fields from the pinned manifest for publication and validation. Categories remain organizational labels; screenshot requirements belong to PR review rather than the submission gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry now reads display metadata from the pinned
paseo-plugin.json, with existinglistingoverrides taking precedence per field. Selecting the Themes category no longer rejects a submission for lacking screenshots; the PR reviewer determines what the plugin does and applies the content requirements.Refs #152.
Changes
paseo-listing.jsonreader with one manifest metadata resolver shared by publication and artifact validation. npm reads use the verified tarball; Git reads use the pinned commit and plugin directory.listing.name,listing.icon, andlisting.media, including an explicit empty media array. Keep the issue title's existing name override. No records are migrated or renamed.Verification
npm test: 140 tests passed. Includes real npm tarballs, pinned Git fixtures, per-field overrides, empty media overrides, ignoring the retired listing file, and a submission reaching PR creation without screenshots.npm run validate: 210 records well-formed.npm run validate -- --online: all 210 records matched their pinned artifacts.npm run build: generated all 210 listings. Checked the generated index's public schema and every existing record override.Scope
No changes to plugin records, the published index format, overview/provenance rules, or getpaseo/paseo. No issue comments or live submission runs were made. Screenshot and content decisions remain with the existing PR review workflow.