fix: patch moderate security vulnerabilities across JS/TS projects#290
Open
Nick Robinson (nickrobinson) wants to merge 1 commit into
Open
fix: patch moderate security vulnerabilities across JS/TS projects#290Nick Robinson (nickrobinson) wants to merge 1 commit into
Nick Robinson (nickrobinson) wants to merge 1 commit into
Conversation
- electron, javascript-web, javascript-tui: resolve brace-expansion GHSA-jxxr-4gwj-5jf2 / GHSA-f886-m6hf-6m8v (moderate) via npm audit fix; javascript-tui also fixes ws GHSA-58qx-3vcg-4xpx - react-native-expo: bump fast-xml-parser override 5.5.6 → 5.7.0 (fixes GHSA-jp2q-39xq-3w4g + GHSA-gh4j-gqv2-49f6); brace-expansion, ws, yaml, qs resolved in both npm and yarn lockfiles via audit fix - react-native: bump fast-xml-parser resolution 5.5.6 → 5.7.0; add qs 6.15.2 (GHSA-vs8f-pjqx-3jh3) and yaml 2.8.3 (GHSA-48c2-rrv3-qjmp) resolutions in yarn Remaining (require major version bumps — out of scope): react-native-expo: expo ecosystem packages, postcss, uuid https://claude.ai/code/session_01D2SFCm3sSQecArjtyuJTLH
Nick Robinson (nickrobinson)
requested review from
a team and
Kristopher Johnson (kristopherjohnson)
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency lockfiles (and a few resolution/override pins) across multiple JS/TS subprojects to pick up patch/minor releases that address moderate security advisories (e.g., brace-expansion, ws, fast-xml-parser, qs, yaml).
Changes:
- Regenerated
package-lock.jsonfiles forelectron,javascript-web, andjavascript-tuito pull patched transitive versions (notablybrace-expansionandws). - Updated
react-nativeandreact-native-exporesolution/override pins forfast-xml-parser(and addedqs/yamlpins forreact-native), then regenerated Yarn lockfiles. - Refreshed
react-native-expoYarn dependency graph (numerous transitive bumps) consistent with the stated audit remediation approach.
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| electron/package-lock.json | Lockfile refresh to pick up patched transitive dependencies. |
| javascript-web/package-lock.json | Lockfile-only updates to patched dependency resolutions. |
| javascript-tui/package-lock.json | Lockfile-only updates including patched ws and brace-expansion. |
| react-native/package.json | Updates resolutions to pin patched fast-xml-parser, plus qs/yaml. |
| react-native/yarn.lock | Yarn lock refresh reflecting updated resolutions and patched transitive versions. |
| react-native-expo/package.json | Updates resolutions + overrides to pin patched fast-xml-parser. |
| react-native-expo/yarn.lock | Yarn lock refresh reflecting patched transitive versions from audit fix/regeneration. |
Files not reviewed (3)
- electron/package-lock.json: Language not supported
- javascript-tui/package-lock.json: Language not supported
- javascript-web/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patches all security vulnerabilities addressable via minor/patch version bumps across the JavaScript and TypeScript sub-projects. Major-version-only fixes are called out separately below.
Fixes applied
electron·javascript-web·javascript-tuiAll three resolved via
npm audit fix(lockfile-only updates, no manifest changes):brace-expansionws(javascript-tui only)Result: 0 vulnerabilities in all three projects.
react-native-expoChanges to
package.jsonoverrides and resolutions, plus bothpackage-lock.jsonandyarn.lockregenerated (per repo policy — project ships both lockfiles):fast-xml-parser5.5.6 → 5.7.0brace-expansionwsyamlqsreact-nativeChanges to
package.jsonresolutions +yarn.lockregenerated:fast-xml-parser5.5.6 → 5.7.0qs6.15.2yaml2.8.3MANUAL INTERVENTION REQUIRED
The following vulnerabilities in
react-native-expocannot be resolved without major version bumps and are out of scope for this PR:expo(+ ecosystem:@expo/cli,@expo/config,@expo/config-plugins,@expo/metro-config,@expo/prebuild-config,expo-asset,expo-constants,expo-linking,expo-router,expo-splash-screen,jest-expo,xcode)~54.0.x56.x(major bump)postcss56.xuuid56.x(uuid11.xinternally)Suggested action: upgrade
expofrom~54.0.25to~56.xinreact-native-expo/package.jsonand rerunnpm install+npx yarn install.Projects not covered
rust-tui):cargo-auditnot installed in this environment; manualcargo audit+cargo updaterecommended.go-tui):govulnchecknot available; manualgo get -u ./...recommended.https://claude.ai/code/session_01D2SFCm3sSQecArjtyuJTLH
Generated by Claude Code