chore: Remove yarn setup, rely on npx for @appland/appmap#368
chore: Remove yarn setup, rely on npx for @appland/appmap#368dividedmind merged 1 commit intomasterfrom
Conversation
package.json and yarn.lock only served the rake install task used in the dev/test environment. Since npx resolves @appland/appmap at runtime anyway, the yarn layer adds no value.
There was a problem hiding this comment.
Pull request overview
This PR removes the Yarn-based Node dependency setup (previously used to install @appland/appmap) and shifts the project to relying on runtime npx resolution instead, with corresponding documentation and CI updates.
Changes:
- Remove
package.jsonandyarn.lockand delete therake installtask that ranyarn install. - Update
Rakefiletest task dependencies sospecdepends only oncompile. - Update CI/docs to reflect removal of Yarn (including dropping Node setup from the CI test job and adjusting architecture/CI docs).
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Removes Yarn lockfile (eliminates pinned Node dependency graph). |
package.json |
Removes Node dependency declaration for @appland/appmap. |
Rakefile |
Removes Yarn install task and updates spec prerequisites. |
README_CI.md |
Updates CI documentation wording around repository URL resolution. |
ARCHITECTURE.md |
Updates description of appmap-js integration to runtime npx usage. |
.gitignore |
Stops ignoring /.yarn. |
.github/workflows/ci.yml |
Removes Node setup step from the test job (release job still sets up Node). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -41,11 +41,6 @@ jobs: | |||
| ruby-version: ${{ matrix.ruby }} | |||
| bundler-cache: true | |||
|
|
|||
There was a problem hiding this comment.
The test suite exercises code paths that call out to npx/node (e.g., Depends API specs update the AppMap index via AppMap::NodeCLI). With the Node setup step removed, the job now relies on whatever Node/npm happen to be preinstalled on the runner, which can change and can break CI. Re-add actions/setup-node@v4 (and consider cache: npm) for the test job to make the environment deterministic.
| - uses: actions/setup-node@v4 | |
| with: | |
| node-version: lts/* |
There was a problem hiding this comment.
Non-deterministic is actually good in this case IMO. This reflects more closely how the users will use it and will make it easier to catch any regressions.
package.json and yarn.lock only served the rake install task used in the dev/test environment. Since npx resolves @appland/appmap at runtime anyway, the yarn layer adds no value.