Fix IndexOutOfBoundsException in GitUtil.getRepositoryURL when no remotes configured#326
Open
Fix IndexOutOfBoundsException in GitUtil.getRepositoryURL when no remotes configured#326
Conversation
…otes exist Agent-Logs-Url: https://github.com/getappmap/appmap-java/sessions/2575e3fc-ec41-4655-ab8e-0d6c7f3670b7 Co-authored-by: kgilpin <86395+kgilpin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix recording failure in git repositories without remotes
Fix IndexOutOfBoundsException in GitUtil.getRepositoryURL when no remotes configured
May 5, 2026
…itory key in serializer Agent-Logs-Url: https://github.com/getappmap/appmap-java/sessions/9269e403-28ed-4394-be5f-17ca657e822a Co-authored-by: kgilpin <86395+kgilpin@users.noreply.github.com>
Author
Done in 5956839. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording fails with
IndexOutOfBoundsExceptioninGitUtil.getRepositoryURLwhen the git repository has no remotes — the fallback path ofremotes.get(0)is hit unconditionally on a potentially empty list.Changes
nullearly ifremotes.isEmpty()instead of falling through toremotes.get(0)nullif the selected remote has no URIs configuredorElseGetoverorElse— avoids eagerly evaluatingremotes.get(0)when "origin" is presentgetRepositoryURL()returnsnullinstead of""when no URL is available, allowing callers to distinguish "no remote" from an actual empty stringAppMapSerializer.writeMetadata()only writes therepositorykey whengetRepositoryURL()returns a non-null value