fix(dashboard): bound Daily Activity history scans#727
Open
ihearttokyo wants to merge 1 commit into
Open
Conversation
Reuse one concrete six-month scan for interactive history and selected-period totals. This restores network-backed providers, removes concurrent refresh scans, and keeps non-interactive reports scoped to their requested period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #672 addressing both review findings.
Daily Activity and selected-period totals now share one concrete six-month scan. This gives network-backed providers such as Vercel Gateway the required date range and removes the concurrent unbounded history parse from refreshes. Non-interactive reports continue to scan only their requested period.
The original implementation could silently omit Vercel history and scan unbounded local histories in parallel with the normal dashboard refresh. Regression coverage now pins the bounded range, selected-period derivation, non-interactive scope, and Vercel network path.
Validated with the focused dashboard/Vercel tests, the full root and desktop suites, TypeScript, production build, and live PTY checks at 80×18 and 112×58.
Please feel free to rework or re-implement the patch if that fits the codebase better.
Refs #672