Skip to content

feat(browser): add find in page - #1502

Open
smsunarto wants to merge 3 commits into
get-bb:mainfrom
smsunarto:bb/fix-browser-find-shortcut-thr_vv6tfsyjun
Open

feat(browser): add find in page#1502
smsunarto wants to merge 3 commits into
get-bb:mainfrom
smsunarto:bb/fix-browser-find-shortcut-thr_vv6tfsyjun

Conversation

@smsunarto

Copy link
Copy Markdown
Contributor

Summary

Add Find in Page to embedded desktop browser tabs.

  • Open with ⌘F.
  • Search as the user types.
  • Show the current and total match count.
  • Navigate with buttons, Enter, or Shift+Enter.
  • Close with Escape or the close button.

Design rationale

  • Use Chromium's native Find in Page engine through Electron's webContents.findInPage.
  • Do not reimplement text matching, highlighting, or match navigation in BB.
  • Render only the Find bar in BB because WebContentsView does not include browser chrome.
  • Use BB design-system tokens and existing browser controls for the interface.
  • Route ⌘F through BB's command system so it works from BB chrome and the embedded page.
  • Scope requests and results by browser tab ID.
  • Keep the new desktop APIs optional so older desktop shells remain compatible.
  • Validate Find requests and results at the desktop IPC boundary.
  • Clear native highlights when the bar closes or the page changes.

Testing

  • 61 focused app, desktop, desktop-contract, and server tests pass.
  • Turbo typecheck passes: 4 tasks.
  • Turbo build passes: 8 tasks.
  • Verified real-time search, match counts, match navigation, and closing in the live Electron app.
  • Verified two-tab isolation in both directions with deterministic pages.

AGENT GENERATED: by Claude Mythos 5

@smsunarto smsunarto changed the title fix(browser): add find in page feat(browser): add find in page Aug 13, 2026
@smsunarto
smsunarto marked this pull request as ready for review August 13, 2026 08:29
smsunarto and others added 2 commits August 14, 2026 00:45
Amp-Thread-ID: https://ampcode.com/threads/T-019fff37-031d-72af-bfe4-1bc5399e646b
Co-authored-by: Amp <amp@ampcode.com>

# Conflicts:
#	apps/desktop/src/desktop-browser-view.ts
#	apps/desktop/test/desktop-browser-view-manager.test.ts
#	packages/templates/src/generated/plugin-sdk-dts.generated.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant