Skip to content

fix: decompose and example fixes#772

Closed
AngeloDanducci wants to merge 4 commits intogenerative-computing:mainfrom
AngeloDanducci:ad-755
Closed

fix: decompose and example fixes#772
AngeloDanducci wants to merge 4 commits intogenerative-computing:mainfrom
AngeloDanducci:ad-755

Conversation

@AngeloDanducci
Copy link
Copy Markdown
Contributor

@AngeloDanducci AngeloDanducci commented Apr 1, 2026 •
edited
Loading

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

@AngeloDanducci AngeloDanducci requested a review from a team as a code owner April 1, 2026 14:36
@github-actions github-actions Bot added the bug Something isn't working label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@AngeloDanducci
Copy link
Copy Markdown
Contributor Author

AngeloDanducci commented Apr 1, 2026

@csbobby let me know your input on the templating / pipeline / constraint changes.

@csbobby
Copy link
Copy Markdown
Contributor

csbobby commented Apr 1, 2026 •
edited
Loading

@csbobby let me know your input on the templating / pipeline / constraint changes.

Thank you. Replied on the #755

@csbobby csbobby closed this Apr 1, 2026
@csbobby csbobby reopened this Apr 1, 2026
@csbobby
Copy link
Copy Markdown
Contributor

csbobby commented Apr 1, 2026

Hi Several changes are relevant to the #770, so maybe we can process this after it is merged. The generated tmp files under the ‎docs/examples/m_decompose/python/* could be removed.

planetf1
planetf1 reviewed Apr 7, 2026
View reviewed changes
Comment thread docs/examples/m_decompose/python/validations/val_fn_2.py
# Split the input into sentences using regular expressions
sentences = re.split("[.!?]", input)

# The first sentence should be the introduction
Copy link
Copy Markdown
Contributor

@planetf1 planetf1 Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just checking the sentence has punctuation - could add comments syaing it's a simplification or ideally make stronger? but if generated - and we remove, not relevant?

Copy link
Copy Markdown
Contributor Author

@AngeloDanducci AngeloDanducci Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example I think this is relevant as this is now part of the generated output.

Comment thread docs/examples/m_decompose/python/python_decompose_result.py
@AngeloDanducci AngeloDanducci requested a review from a team as a code owner April 7, 2026 19:10
@AngeloDanducci
Copy link
Copy Markdown
Contributor Author

AngeloDanducci commented Apr 29, 2026

Will open a different PR now that the other changes have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@planetf1 planetf1 planetf1 left review comments

@avinash2692 avinash2692 Awaiting requested review from avinash2692 avinash2692 is a code owner automatically assigned from generative-computing/mellea-maintainers

@markstur markstur Awaiting requested review from markstur markstur is a code owner automatically assigned from generative-computing/mellea-maintainers

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: decompose pipeline KeyError when constraint strings don't exactly match between stages

3 participants

@AngeloDanducci @csbobby @planetf1