Retry session create with exp timeout - #1308
Closed
sonic16x wants to merge 3 commits into
Closed
Conversation
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
sonic16x
force-pushed
the
exp-session-create
branch
3 times, most recently
from
August 7, 2026 06:58
a3891d9 to
599cda3
Compare
commit: |
sonic16x
force-pushed
the
exp-session-create
branch
from
August 7, 2026 08:01
599cda3 to
460ea1d
Compare
| import { Config } from "../config"; | ||
| import { BrowserConfig } from "../config/browser-config"; | ||
| import { BrowserName, type W3CBrowserName } from "./types"; | ||
| import { exponentiallyWait } from "../ws-connection/utils"; |
Member
There was a problem hiding this comment.
Browser should not directly depend on ws-connection utils module
If you want to use "exponentiallyWait" here, its better to pull "exponentiallyWait" to generic utils, which will be used both in ws-connection and browser
added 2 commits
August 7, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.