feat: add release 0.0.0 version substitution to run configuration and updat…#163
Open
omkargaikwad23 wants to merge 6 commits intomainfrom
Open
feat: add release 0.0.0 version substitution to run configuration and updat…#163omkargaikwad23 wants to merge 6 commits intomainfrom
omkargaikwad23 wants to merge 6 commits intomainfrom
Conversation
…e cloudbuild environment variables
omkargaikwad23
added
autorelease: triggered
omkargaikwad23
changed the title
… branches in cloudbuild.yaml
…I using secret token
… release branches
| # limitations under the License. | ||
|
|
||
| extension_id: cloud-sql-postgresql | ||
| release_version: ${RELEASE_VERSION} |
Contributor
There was a problem hiding this comment.
I think we should use separate yaml file this can be confusing we want to have standard config files across evalbench
| - versionName: projects/$PROJECT_ID/secrets/daily-ci-evals-db-password/versions/latest | ||
| env: 'DB_PASSWORD' | ||
| - versionName: projects/$PROJECT_ID/secrets/GITHUB_TOKEN/versions/latest | ||
| env: 'GITHUB_TOKEN' No newline at end of file |
Contributor
There was a problem hiding this comment.
nit add a new line
|
|
||
| # Fetch PR data using curl approach | ||
| PR_DATA=$(curl -s -H "Authorization: token $$GITHUB_TOKEN" \ | ||
| "https://api.github.com/repos/$REPO_FULL_NAME/pulls/$_PR_NUMBER") |
Contributor
There was a problem hiding this comment.
if the curl call fails (e.g., bad token, rate limit), PR_DATA will be empty and RELEASE_VERSION silently becomes "unknown". Consider adding a check on the HTTP status.
| "https://api.github.com/repos/$REPO_FULL_NAME/pulls/$_PR_NUMBER") | ||
|
|
||
| # Extract labels and title from PR data (Use $$ to escape bash variables) | ||
| PR_LABELS=$(echo "$$PR_DATA" | jq -r '.labels[].name' | paste -sd ',') |
Contributor
There was a problem hiding this comment.
Behavior might differ on some linux machines for: paste -sd ','
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e cloudbuild environment variables