Repository navigation
kernel: pass mutability on explicitly to new lists - #6704
Merged
Merged
Conversation
Some functions create their result with the tnum of an argument, and thereby give it the mutability of that argument: ZeroSameMutability for plain lists of FFEs, sums and differences of a cyclotomic vector and a scalar, and REDUCE_LETREP_WORDS_REW_SYS. Say so explicitly, so that this keeps working once mutability is no longer part of the tnum (see #6025). Assisted-by: Claude Code (Opus 5.5)
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6704 +/- ##
=======================================
Coverage 79.57% 79.57%
=======================================
Files 683 683
Lines 295429 295434 +5
Branches 8648 8648
=======================================
+ Hits 235091 235097 +6
Misses 58518 58518
+ Partials 1820 1819 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
approved these changes
Oct 8, 2026
james-d-mitchell
left a comment
james-d-mitchell
left a comment
Contributor
There was a problem hiding this comment.
This looks like a sensible change to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions create their result with the tnum of an argument, and thereby give it the mutability of that argument:
ZeroSameMutabilityfor plain lists of FFEs, sums and differences of a cyclotomic vector and a scalar, andREDUCE_LETREP_WORDS_REW_SYS. Change this to be explicit, so that this keeps working once mutability is no longer part of the tnum (see #6025).Assisted-by: Claude Code (Opus 5.5)