Skip to content

tst: test that kernel functions keep mutability - #6703

Merged
fingolfin merged 1 commit into
masterfrom
mh-claude/kernel-mutability-tests
Oct 8, 2026
Merged

fingolfin merged 1 commit into
masterfrom
mh-claude/kernel-mutability-tests

Conversation

@fingolfin

Copy link
Copy Markdown
Member

Cover places where the mutability of an object travels with its tnum or its type: converting compressed vectors and matrices back to plain lists, CLONE_OBJ, turning a plain list into a positional object, setting the IsMutable filter again after MakeImmutable, and the HPC-GAP serializer. These are the places that need care when mutability moves out of the tnum (see #6025).

Assisted-by: Claude Code (Opus 5.5)

Cover places where the mutability of an object travels with its tnum
or its type: converting compressed vectors and matrices back to plain
lists, CLONE_OBJ, turning a plain list into a positional object,
setting the IsMutable filter again after MakeImmutable, and the HPC-GAP
serializer. These are the places that need care when mutability moves
out of the tnum (see #6025).

Assisted-by: Claude Code (Opus 5.5)
@fingolfin
fingolfin requested review from dvberkel and stertooy October 8, 2026 13:06
@fingolfin fingolfin added topic: tests issues or PRs related to tests release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Oct 8, 2026
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.57%. Comparing base (512ea92) to head (c58b304).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6703   +/-   ##
=======================================
  Coverage   79.57%   79.57%           
=======================================
  Files         683      683           
  Lines      295429   295431    +2     
  Branches     8648     8649    +1     
=======================================
+ Hits       235091   235093    +2     
+ Misses      58518    58517    -1     
- Partials     1820     1821    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fingolfin
fingolfin merged commit 482ebce into master Oct 8, 2026
34 checks passed
@fingolfin
fingolfin deleted the mh-claude/kernel-mutability-tests branch October 8, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants