Conversation
The simulator sometimes runs every test and then aborts during teardown with SIGABRT, which xcodebuild reports as exit code 134. It is a simulator fault, not a failing test, and the only remedy so far was to rerun the job by hand (it hit the visionOS job on run 32100416044). The step now runs xcodebuild through a function and retries it once on 134 alone; every other non-zero status still fails the job immediately, so a real failure is never retried into a pass. A hang that trips timeout-minutes is cancelled by the runner and is not covered. Same change as TLDExtractSwift, which shares this workflow.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The simulator test jobs occasionally run every test and then abort during teardown with SIGABRT, which
xcodebuildreports as exit code 134. It is a simulator fault rather than a failing test — the last occurrence was the visionOS job on run 32100416044 (Abort trap: 6after the suite had finished), and the documented remedy was to rerun the job by hand.The simulator step now runs
xcodebuildthrough arun_testsfunction and retries it once on 134 alone. Any other non-zero status still fails the job immediately, so a real test failure is never retried into a pass. A hang that tripstimeout-minutesis cancelled by the runner and is not covered by this.This is the same change TLDExtractSwift made; the two repositories share this workflow, so they stay identical.
Changes
.github/workflows/main.yml: 134-only retry in thetest_simulatorsstep.CLAUDE.md: the flake note records that 134 is now retried once and that a timeout is not.CHANGELOG.md: entry under Unreleased.Verification
bash -n(GitHub expressions stubbed out).