Conversation
Give lint_code a 10 minute timeout, matching every other job except the simulator matrix, so a hung swift-format run cannot sit on a runner until GitHub's default limit. CLAUDE.md's CI note drops the "lint_code sets none" caveat accordingly. CLAUDE.md also gains a Swift Package Index section: what each .spi.yml key does, why --include-extended-types is required, why metadata.authors has to be a complete sentence, and why edits to the file take up to 24 hours to show (Analyze.throttle holds the stored default-branch version until the commit SPI already has is a day old, while tag analysis skips the throttle). TLDExtractSwift documents the same behaviour.
The repository already lists maintainer-only work under a "Maintainer tooling:" prefix -- 4.0.2 shipped the fastlane version lane fix that way -- so the CLAUDE.md notes and the lint job timeout belong there too rather than going unrecorded.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #93, matching TLDExtractSwift's PR #69.
.github/workflows/main.yml:lint_codegainstimeout-minutes: 10. It was the only job without one, so a hungswift-formatrun would have sat on a runner until GitHub's default limit. Every job except the simulator matrix (15) now uses 10.CLAUDE.md: the CI flake note drops its "lint_codesets none" caveat, which the workflow change makes untrue.CLAUDE.md: new Swift Package Index section covering what.spi.ymlcontrols — why--include-extended-typesis required (the public API is entirely extensions onString/Substring, so SPI's DocC site would otherwise be nearly empty), whymetadata.authorsmust be a complete sentence (SPI prints it verbatim, capped at 200 characters), and why edits take up to 24 hours to appear.The last point is the one that cost time today:
Analyze.throttle()keeps the stored default-branch version until the commit SPI already holds is 24 hours old (Constants.branchVersionRefreshDelay), andversion.spiManifestis only written during that pass. Merging again does not reset the timer; tag analysis skips the throttle entirely, which is why 4.0.2 appeared as "Latest Release" the same day while the author line did not move. It is designed behaviour, not a bug.Test plan
.github/workflows/main.ymlparses as valid YAML; the diff is the singletimeout-minutesline.