Merged
Conversation
e0ceaef to
17c5b07
Compare
xperiandri
commented
Apr 19, 2026
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the repo to target .NET 10 / F# 10 and bumps the package to 4.0.0, along with a breaking API change in Relay’s Edge type.
Changes:
- Target framework/language/runtime versions updated (net10.0, FSharp.Core 10, CI SDK 10.0.202)
- NuGet package version bumped to 4.0.0 and release notes updated for breaking changes
- Relay
Edge<'Node>changed from a reference record to a struct record
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/FSharp.Data.GraphQL.Server.Relay/Connections.fs | Makes Edge<'Node> a struct (breaking API/runtime semantics change) |
| RELEASE_NOTES.md | Adds 4.0.0 unreleased notes and mentions breaking changes |
| Directory.Build.props | Switches target framework/lang/core versions and bumps package version to 4.0.0 |
| .github/workflows/pull-request.yml | Updates CI SDK to 10.0.202 |
| .github/workflows/publish-release.yml | Updates release pipeline SDK to 10.0.202 |
| .github/workflows/publish-ci.yml | Updates CI publish SDK to 10.0.202 |
| .github/workflows/copilot-setup-steps.yml | Updates setup steps to install .NET 10.x |
b1ed51d to
b5bab89
Compare
Co-authored-by: Andrii Chebukin <XperiAndri@Outlook.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the repo’s build/test infrastructure and several projects to .NET 10 / F# 10, including updating hosting to Host.CreateDefaultBuilder and aligning CI/build tooling.
Changes:
- Update build scripts and GitHub Actions workflows to use a .NET 10 SDK version and
net10.0moniker. - Migrate sample/test server hosting to the Generic Host (
Host.CreateDefaultBuilder+ConfigureWebHostDefaults). - Introduce shared variable mapping helper and make Relay
Edgea struct.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/FSharp.Data.GraphQL.IntegrationTests/FSharp.Data.GraphQL.IntegrationTests.fsproj | Removes explicit BCL package references likely covered by the framework in newer TFMs. |
| tests/FSharp.Data.GraphQL.IntegrationTests.Server/Program.fs | Switches integration test server startup to Generic Host. |
| tests/FSharp.Data.GraphQL.IntegrationTests.Server/FSharp.Data.GraphQL.IntegrationTests.Server.fsproj | Removes Microsoft.Extensions.Http package reference. |
| src/FSharp.Data.GraphQL.Server.Relay/Connections.fs | Makes Relay Edge a struct (breaking change). |
| src/FSharp.Data.GraphQL.Client/BaseTypes.fs | Adds reusable VariableMapping.mapVariableValue. |
| src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs | Reuses VariableMapping.mapVariableValue in provided-code quotation. |
| samples/star-wars-api/Program.fs | Migrates sample app startup to Generic Host. |
| samples/relay-book-store/relay-book-store.fsproj | Removes explicit BCL package references likely covered by the framework. |
| build/Program.fs | Pins .NET SDK to 10.x, updates moniker, improves process output handling, adds explicit integration test build target, improves fsdocs error handling. |
| RELEASE_NOTES.md | Formats release notes and adds “4.0.0 – Unreleased” items for .NET 10 migration. |
| Directory.Build.props | Moves to net10.0 / F# 10, bumps package version to 4.0.0. |
| .github/workflows/pull-request.yml | Updates CI matrix to use .NET SDK 10.0.202. |
| .github/workflows/publish-release.yml | Updates release pipeline to .NET SDK 10.0.202. |
| .github/workflows/publish-ci.yml | Updates CI publish pipeline to .NET SDK 10.0.202. |
| .github/workflows/copilot-setup-steps.yml | Updates setup step to include 10.x. |
Comments suppressed due to low confidence (1)
samples/star-wars-api/Program.fs:10
- The function name
buildWebHostis now misleading since it returns a Generic Host (Host.CreateDefaultBuilder) rather than usingWebHost. Renaming to something likebuildHostwould keep terminology consistent with what the function builds.
let buildWebHost (args : string array) =
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.