Skip to content

Migrated to .NET 10#548

Merged
xperiandri merged 11 commits intodevfrom
net10
Apr 20, 2026
Merged

Migrated to .NET 10#548
xperiandri merged 11 commits intodevfrom
net10

Conversation

@xperiandri
Copy link
Copy Markdown
Collaborator

No description provided.

@xperiandri xperiandri force-pushed the net10 branch 2 times, most recently from e0ceaef to 17c5b07 Compare April 19, 2026 15:38
@xperiandri xperiandri requested a review from Copilot April 19, 2026 15:38
Comment thread .github/workflows/publish-ci.yml Outdated
Comment thread .github/workflows/publish-release.yml Outdated
Comment thread .github/workflows/pull-request.yml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the repo to target .NET 10 / F# 10 and bumps the package to 4.0.0, along with a breaking API change in Relay’s Edge type.

Changes:

  • Target framework/language/runtime versions updated (net10.0, FSharp.Core 10, CI SDK 10.0.202)
  • NuGet package version bumped to 4.0.0 and release notes updated for breaking changes
  • Relay Edge<'Node> changed from a reference record to a struct record

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/FSharp.Data.GraphQL.Server.Relay/Connections.fs Makes Edge<'Node> a struct (breaking API/runtime semantics change)
RELEASE_NOTES.md Adds 4.0.0 unreleased notes and mentions breaking changes
Directory.Build.props Switches target framework/lang/core versions and bumps package version to 4.0.0
.github/workflows/pull-request.yml Updates CI SDK to 10.0.202
.github/workflows/publish-release.yml Updates release pipeline SDK to 10.0.202
.github/workflows/publish-ci.yml Updates CI publish SDK to 10.0.202
.github/workflows/copilot-setup-steps.yml Updates setup steps to install .NET 10.x

Comment thread src/FSharp.Data.GraphQL.Server.Relay/Connections.fs Outdated
Comment thread RELEASE_NOTES.md Outdated
@xperiandri xperiandri force-pushed the net10 branch 2 times, most recently from b1ed51d to b5bab89 Compare April 19, 2026 22:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Migrates the repo’s build/test infrastructure and several projects to .NET 10 / F# 10, including updating hosting to Host.CreateDefaultBuilder and aligning CI/build tooling.

Changes:

  • Update build scripts and GitHub Actions workflows to use a .NET 10 SDK version and net10.0 moniker.
  • Migrate sample/test server hosting to the Generic Host (Host.CreateDefaultBuilder + ConfigureWebHostDefaults).
  • Introduce shared variable mapping helper and make Relay Edge a struct.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/FSharp.Data.GraphQL.IntegrationTests/FSharp.Data.GraphQL.IntegrationTests.fsproj Removes explicit BCL package references likely covered by the framework in newer TFMs.
tests/FSharp.Data.GraphQL.IntegrationTests.Server/Program.fs Switches integration test server startup to Generic Host.
tests/FSharp.Data.GraphQL.IntegrationTests.Server/FSharp.Data.GraphQL.IntegrationTests.Server.fsproj Removes Microsoft.Extensions.Http package reference.
src/FSharp.Data.GraphQL.Server.Relay/Connections.fs Makes Relay Edge a struct (breaking change).
src/FSharp.Data.GraphQL.Client/BaseTypes.fs Adds reusable VariableMapping.mapVariableValue.
src/FSharp.Data.GraphQL.Client.DesignTime/ProvidedTypesHelper.fs Reuses VariableMapping.mapVariableValue in provided-code quotation.
samples/star-wars-api/Program.fs Migrates sample app startup to Generic Host.
samples/relay-book-store/relay-book-store.fsproj Removes explicit BCL package references likely covered by the framework.
build/Program.fs Pins .NET SDK to 10.x, updates moniker, improves process output handling, adds explicit integration test build target, improves fsdocs error handling.
RELEASE_NOTES.md Formats release notes and adds “4.0.0 – Unreleased” items for .NET 10 migration.
Directory.Build.props Moves to net10.0 / F# 10, bumps package version to 4.0.0.
.github/workflows/pull-request.yml Updates CI matrix to use .NET SDK 10.0.202.
.github/workflows/publish-release.yml Updates release pipeline to .NET SDK 10.0.202.
.github/workflows/publish-ci.yml Updates CI publish pipeline to .NET SDK 10.0.202.
.github/workflows/copilot-setup-steps.yml Updates setup step to include 10.x.
Comments suppressed due to low confidence (1)

samples/star-wars-api/Program.fs:10

  • The function name buildWebHost is now misleading since it returns a Generic Host (Host.CreateDefaultBuilder) rather than using WebHost. Renaming to something like buildHost would keep terminology consistent with what the function builds.
let buildWebHost (args : string array) =

Comment thread build/Program.fs
Comment thread .github/workflows/pull-request.yml
Comment thread Directory.Build.props
Comment thread samples/star-wars-api/Program.fs
Comment thread src/FSharp.Data.GraphQL.Server.Relay/Connections.fs Outdated
@xperiandri xperiandri merged commit a893d30 into dev Apr 20, 2026
4 checks passed
@xperiandri xperiandri deleted the net10 branch April 20, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants