Repository navigation
ci: run the wiki-write-core publish npm steps outside the workspace - #4034
Merged
Merged
Conversation
fro-bot
approved these changes
Oct 21, 2026
fro-bot
left a comment
fro-bot
left a comment
Owner
There was a problem hiding this comment.
Verdict: PASS
The step-scoped setting skips npm’s post-version workspace reification, addressing the reported EOVERRIDE. The pinned semantic-release npm plugin forwards it to its npm subprocesses.
Blocking issues
None
Non-blocking concerns
None
Missing tests
None required beyond the updated configuration contract for this narrow fix. All 70 workflow tests passed locally; live OIDC publication was not exercised.
Risk assessment (LOW/MED/HIGH) + rationale
LOW — one documented npm setting, scoped to the release step, with a matching regression assertion. Upstream npm and plugin source confirm the intended behavior.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/.github |
| Run ID | 39632503219 |
| Cache | hit |
| Session | ses_ea0c339cdffeHTPz4aqef3fpgd |
| Verification | 70 workflow tests passed; upstream source checked |
| Limitations | Direct review; skill helper and scratch-probe access blocked by sandbox; actionlint unavailable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #4021 moved
workspacesandoverridesinto the rootpackage.json, the wiki-write-core publish has been failing. Runningnpm versionornpm publishinsidepackages/wiki-write-corenow resolves the root as a workspace and tries to reify the whole tree. npm then fails on the rootyamloverride withEOVERRIDE: Override for yaml@^2.6.0 conflicts with direct dependency. The publish job failed this way on #4032, #4029 and #4033, in runs 39622360119, 39625473187 and 39630004612. Each failure came before semantic-release tagged anything, so nowiki-write-core-v0.1.2tag or release exists.Setting
npm_config_workspaces_update: 'false'on the semantic-release step makes npm treat the package as a standalone package, which is how it ran under pnpm. Permissions, tokens, pins and the environment are unchanged.Verification
git archivecopy ofpackage.jsonandpackages/wiki-write-core,npm version 0.1.2 --no-git-tag-versionexits 1 with EOVERRIDE when the variable is unset, and exits 0 when it is set.npm publish --dry-runwith the variable set reports@fro.bot/wiki-write-core@0.1.2.check-types,lint,test(5795 passed) and actionlint pass, and the workflow contract test pins the new env value.