Create append helper function and set $schema as first attribute - #366
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #366 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 792 807 +15
=========================================
+ Hits 792 807 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…eplacement needed
Member
|
I've added the requested tests, could you have another look @peterdesmet to see if I've covered everything you had in mind? |
And shorten test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #358
Originally written by @PietrH in #362 Edited text from original PR:
TODO
check_package()data_locationandpathto be retained)append_with_attributes()$schemais first property