Skip to content

Create public append() function - #365

Closed
peterdesmet wants to merge 5 commits into
mainfrom
append-function
Closed

peterdesmet wants to merge 5 commits into
mainfrom
append-function

Conversation

@peterdesmet

@peterdesmet peterdesmet commented Aug 26, 2026 •

Copy link
Copy Markdown
Member

Fix #198

Originally written by @PietrH in #362. Edited text from original PR:

I ended up implementing a generic S3 method for append() which allowed me to set a S3 method for append.datapackage().

Converting append() to a generic S3 method will result in a message when loading frictionless:

Attaching package: ‘frictionless’

The following object is masked from ‘package:base’:

    append

This can be avoided by not using S3 dispatch at all, and using the internal helper for packages as well. But then users will not be able to call append() on a datapackage without dropping attributes.

TODO

  • Add tests
  • Do we need to use base::append() in append_with_attributes() tests?
  • Merge append_with_attrs() functionality into this branch
  • Search for append in documentation and update (e.g. in vignettes)
  • Assign a function family and decide where to list in pkgdown

Originally written by @PietrH in #362

Co-Authored-By: Pieter Huybrechts <48065851+PietrH@users.noreply.github.com>
@codecov

codecov Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.87%. Comparing base (c49bc26) to head (ad0813e).

Files with missing lines Patch % Lines
R/append.datapackage.R 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #365      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files           28       29       +1     
  Lines          827      830       +3     
===========================================
+ Hits           827      829       +2     
- Misses           0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterdesmet
peterdesmet changed the base branch from v2 to main September 10, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

append() drops custom datapackage class

2 participants