Skip to content

Fix scoped external-search shortcuts #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix scoped external-search shortcuts #2729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/javascripts/views/search/search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ app.views.Search = class Search extends app.View {
}

externalSearch(url) {
const value = this.value;
let value = this.value;
if (value) {
if (this.scope.name()) {
value = `${this.scope.name()} ${value}`;
Expand Down
16 changes: 16 additions & 0 deletions test/assets/search_hash_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,19 @@ test("URL search hash preserves encoded literal plus signs in the query", () =>

assert.equal(search.getHashValue(), "operator+");
});

test("scoped external search includes the documentation name", () => {
let popupUrl;
context.$.popup = (url) => {
popupUrl = url;
};

const search = Object.create(context.app.views.Search.prototype);
search.value = "status";
search.scope = { name: () => "Git" };
search.reset = () => {};

search.externalSearch("https://www.google.com/search?q=");

assert.equal(popupUrl, "https://www.google.com/search?q=Git%20status");
});