Skip to content

api: Count devices that rolled back after a failed update apart - #319

Open
detsch wants to merge 1 commit into
foundriesio:mainfrom
detsch:detsch/rollout-summary-rolled-back
Open

detsch wants to merge 1 commit into
foundriesio:mainfrom
detsch:detsch/rollout-summary-rolled-back

Conversation

@detsch

@detsch detsch commented Oct 29, 2026

Copy link
Copy Markdown
Member

A device that fails an update usually rolls back to its previous target, so most devices counted as failed have recovered. Count a device whose failed installation of the update's target is followed by a successful installation of another target as rolled back, and keep failed for the devices that did not recover.


Follow-up based on discussion at #311

@doanac @vkhoroz this may make things more clear to the users.

A device that fails an update usually rolls back to its previous
target, so most devices counted as failed have recovered. Count a
device whose failed installation of the update's target is followed
by a successful installation of another target as rolled back, and
keep failed for the devices that did not recover.

Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@detsch
detsch requested review from doanac and vkhoroz October 29, 2026 13:26

@doanac doanac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Let's see what @vkhoroz thinks

@vkhoroz vkhoroz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.
I think it is an awesome alternative way to showing two events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants