Repository navigation
Conversation
|
Coverage is 66.001% — jodavies:pr-874-regression into form-dev:master. No base build found for |
The is a regression due to 13f03ab. Since we have removed intermediate calls of Normalize, SUBEXPRESSIONs can survive in the terms later, when we sort the argument, for example when dollar variables are replaced. Allow such terms, and move the dirty check after this normalize and sort.
jodavies
force-pushed
the
pr-874-regression
branch
from
October 13, 2026 14:38
ee0c4f1 to
f82dab7
Compare
Collaborator
Author
|
I don't see any performance impact in form-bench due to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The is a regression due to 13f03ab. Since we have removed intermediate calls of Normalize, SUBEXPRESSIONs can survive in the terms later, when we sort the argument, for example when dollar variables are replaced. Allow such terms, and move the dirty check after this normalize and sort.
Closes #916