Skip to content

Stop package_delay_hides_then_reveals flaking on its 1-second delay #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schmitch merged 1 commit into from
Oct 28, 2026
Merged

Stop package_delay_hides_then_reveals flaking on its 1-second delay #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions crates/core/tests/proxy_read.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,8 +713,10 @@ async fn package_delay_hides_then_reveals() {
corpus.insert("sample.lib".to_string(), vers);
let mock = start_mock(corpus).await;

// 1-second delay window.
let repo = make_proxy(&pool, &format!("{}/index.json", mock.base), 1, true).await;
// A one-hour delay window, which no runner is slow enough to pass between
// two calls: a 1-second one passed between the listing and the download
// on CI's loaded `test` job (#604).
let repo = make_proxy(&pool, &format!("{}/index.json", mock.base), 3600, true).await;
let px = proxy_repo(&pool, cas, cache);

// Inside the window: hidden from enumeration, 404 on direct download.
Expand Down Expand Up @@ -748,8 +750,16 @@ async fn package_delay_hides_then_reveals() {
"delay-gated 404 must never set the negative cache"
);

// After the window elapses, it becomes visible and downloadable.
tokio::time::sleep(std::time::Duration::from_millis(1100)).await;
// After the window elapses, it becomes visible and downloadable. The
// window elapses without a sleep: the version was first seen two hours ago.
sqlx::query(
"UPDATE proxy_cached_version SET first_seen_at = now() - interval '2 hours' \
WHERE repository_id = $1",
)
.bind(repo_id(&pool, &repo).await)
.execute(&pool)
.await
.unwrap();
let versions = px.list_versions(&repo, "Sample.Lib").await.unwrap();
assert_eq!(
versions.len(),
Expand Down
Loading