Repository navigation
Widen L1 cache TTL test windows to reduce CI flakes - #472
Conversation
Co-authored-by: schmitch <1641401+schmitch@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow test-only changes match the requested timing adjustments, preserve behavioral checks, and have no identified blocking issues.
No open issues 🎉
What changed in this PR
This PR addresses #471 by widening timing windows in two L1 cache tests to reduce CI flakes without changing production behavior or removing assertions.
Changes:
- Increase factory-lifetime and TTL windows, with waits that preserve lifetime-expiry and TTL-capping checks.
- Increase the TTL-expiry test’s TTL to 1 second and expiry wait to 1.5 seconds.
- Add a changelog fragment documenting the test reliability improvement.
| File | Description |
|---|---|
| docs/changes/2.0.0/471.fixed.md | Documents the wider test timing windows. |
| crates/cache/tests/l1_unit.rs | Adjusts lifetimes, TTLs, waits, and messages while preserving assertions. |
Review effort: Balanced
Two L1 cache tests allow only 100 ms between insertion and a cache-hit assertion, causing spurious failures on busy CI runners.