Repository navigation
npm: name access levels in the docs, and test a content selector on a write grant - #465
Merged
Merged
Conversation
…rant Since main's access levels (#460), a grant gives the level read, write or delete, each including the ones below, and a content selector on a write grant filters reads too. The npm docs and the repository form's help text said "permission"; they now name the levels, deployment.md's table of levels names npm's publish, dist-tags, deprecations and unpublish, and format-plugins.md's layout lists crates/formats/npm. The new test gives a user write on @acme/* only: it publishes and tags @acme packages, reads nothing else (packuments, tarballs, search), and is refused a publish, a dist-tag and a deprecation outside the scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BaGpNGgkQV54XvgL5D9ay2
main now holds #463, this branch's former base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BaGpNGgkQV54XvgL5D9ay2
schmitch
enabled auto-merge
October 24, 2026 15:15
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 24, 2026
Member
Author
|
The merge queue's first run of this PR (run 768) failed two checks. Neither comes from this PR's change; both passed on the PR's own run of the same tree.
The re-queued run uses the same script, so it can hit the race again until #468 merges. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #463 (npm registries), found by checking it against what
mainchanged while it was open, chiefly the access levels of #460. It was stacked on #463's branch while that sat in the merge queue; #463 has merged, and this PR now targetsmain. It fixes no issue of its own, and npm behaves the same before and after it.Changes
read,writeordelete, each including the ones below it.docs/npm.md, the npm changelog fragment and the repository form's deployment-policy help text said "the write/delete permission"; they now name the levels. The Permissions table indocs/npm.mdhas a Level column and links todeployment.md#access-levels.docs/deployment.md. The table of access levels and thewriterrole now name npm's publish, dist-tags and deprecations (write) andnpm unpublish(delete). "delete tags" now reads "delete image tags": removing an npm dist-tag takeswrite.docs/format-plugins.md. The crate layout listscrates/formats/npmnext to NuGet and raw.writegrant filters reads as well as publishes.a_selector_on_a_write_grant_scopes_publishes_and_readsgives a userwriteon@acme/*only. The user publishes and tags@acmepackages and reads nothing else: packument (abbreviated and full), tarball and search. A publish outside the scope answers 403, and a dist-tag or a deprecation outside it answers 404.unpublishing_takes_the_delete_permissionis renamedunpublishing_takes_the_delete_level, and a comment instate.rsnow lists npm among the formats with all three kinds.Tests
Run locally:
cargo fmt --all --check;cargo clippy --workspace --all-targets --all-features -- -D warnings;cargo xtask changelog --checkcargo test -p forge-server --test npm: 13 passedtsc,vitest(417)🤖 Generated with Claude Code
https://claude.ai/code/session_01BaGpNGgkQV54XvgL5D9ay2