[forgeblueai]

Upstream PR php/php-src#24618 currently carries an implementation-only flag in a public header. That triggers PHP's filename-based ABI break label and unnecessarily changes its header surface.

This lab change relocates PHP_BASE64_FALLIBLE into ext/standard/base64.c while preserving all five allocation paths and the existing C caller flags. It updates the lab's reproducible patch, dry-run submission kit and upstream documentation from three files to two (base64.c and the existing Base64 PHPT). No upstream code is modified by this lab PR.

Validation gates

• git apply --check succeeds on current PHP-8.4
• Previous unpatched behavior 137/no shutdown, patched behavior 255/shutdown in NTS and ZTS
• 9/9 targeted PHPT tests pass in NTS and ZTS
• Updated upstream submission kit stages only two files
• No unintended change to exported C header

After evidence is reviewed, sync the same adjustment to existing upstream draft PR #24618, not a new upstream PR. Its original official CI checks may restart after this revision.

[forgeblueai]

Validated private Base64 flag revision (upstream-compatible)

Latest lab commit cb559fca3074aa4ac16003e8e699348840ae6c9f moves PHP_BASE64_FALLIBLE to ext/standard/base64.c, so the public ext/standard/base64.h remains identical to upstream.

Verified CI:

• Current PHP-8.4 HEAD NTS+ZTS: both 9/9 PHPT PASS, before hard limit exit 137/no shutdown → after soft OOM exit 255/shutdown.
• Pinned 8.4.27 and 8.5.12 debug builds + patched ASan/UBSan: all 3 jobs PASS.
• Pinned ZTS 8.4.27 and 8.5.12 and PHP-8.4 applicability: all 3 jobs PASS.
• Two-file submission kit dry run: PASS; precisely base64.c and the new upstream PHPT staged, no publication.

The corresponding change was pushed to the existing upstream topic branch (commit b179816e47df86b6bcb350380016f1e01089f172), and php/php-src#24618 now has 2 changed files. Official CI restarted and remains pending; the PR remains Draft.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-23T18:46:26.239863Z	cb559fc	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.