fix(deps): one scope per commit message, not two - #10
Merged
Conversation
`include: scope` makes Dependabot append its own `(deps)` to whatever prefix it is given, so a prefix that already carries a scope produces the doubled shape. The first bump under the new config landed as `chore(backend-deps)(deps): bump ...`, which is not a conventional commit and not what the buckets with a plain `chore` prefix produce. Dropped `include: scope` from every bucket whose prefix already names its scope, and left it on the ones whose prefix is bare. wind's own config warned about exactly this in its header comment and then did it anyway in the example bucket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drops
include: scopefrom the Dependabot buckets whoseprefixalready carries a scope.Why
include: scopeappends Dependabot's own(deps), so a prefix likechore(backend-deps)produceschore(backend-deps)(deps): bump .... The first bump under the new config landed exactly that shape.wind's config header warned about this ("'include: scope' appends '(deps)' automatically, keep prefix parens-free") and its own example bucket did it anyway, so the same fix applies there.
Testing
Config parses; the affected buckets now carry a prefix and no
include, the bare-prefix buckets keep it.