Skip to content

fix(device_info_plus): close registry keys and use win32's RtlGetVersion#3809

Open
halildurmus wants to merge 1 commit intofluttercommunity:mainfrom
halildurmus:device_info_plus
Open

fix(device_info_plus): close registry keys and use win32's RtlGetVersion#3809
halildurmus wants to merge 1 commit intofluttercommunity:mainfrom
halildurmus:device_info_plus

Conversation

@halildurmus
Copy link
Copy Markdown

Description

  • Closes currentVersionKey and sqmClientKey registry keys after use to prevent memory leaks and other potential issues
  • Replaces the manual lookup for RtlGetVersion API with the one provided by package:win32

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant