Skip to content

refactor(share_plus): use win32's RtlGetVersion instead of manual lookup#3807

Open
halildurmus wants to merge 1 commit intofluttercommunity:mainfrom
halildurmus:share_plus
Open

refactor(share_plus): use win32's RtlGetVersion instead of manual lookup#3807
halildurmus wants to merge 1 commit intofluttercommunity:mainfrom
halildurmus:share_plus

Conversation

@halildurmus
Copy link
Copy Markdown

Description

Simplifies the Windows version check in VersionHelper by replacing the manual lookup for RtlGetVersion API with the one provided by package:win32.

This also removes the redundant zero-initialization of all OSVERSIONINFOEX fields — calloc already zero-initializes allocated memory, so only dwOSVersionInfoSize needs to be set explicitly as required by the API.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant