Repository navigation
Conversation
elliette
marked this pull request as ready for review
October 29, 2026 17:57
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Material 3 Expressive (2025) typography defaults, adding Typography.material2025 and corresponding emphasized text styles to TextTheme. It updates ThemeData to use these new defaults when useMaterial3 is true and adds platform-specific typeface text themes. Feedback suggests refactoring the switch expression in Typography.material2025 to handle a nullable platform parameter directly, avoiding the null-assertion operator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Material 3 Expressive typography to
material_ui.New APIs:
Typography.material2025: a new factory constructor for M3 Expressive typography. NOTE:.material2025replaces.material2021as the default whenuseMaterial3is true. Baseline styles are the same asmaterial2021, butmaterial2025adds 15 new emphasized styles as well.Typography.englishLike2025,Typography.dense2025, andTypography.tall2025TextTheme: an emphasized variant of each of the 15 baseline styles (e.g.TextTheme.titleMediumEmphasized). Only set by default when typography is created withmaterial2025.Typography.mountainView,Typography.redmond,Typography.helsinki,Typography.cupertino, andTypography.redwoodCity.Demo (in
material_ui/example):Fixes flutter/flutter#184933
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2