[elliette]

This reverts commit a8549ae.

I accidentally added autosubmit to #13443. I wanted to keep it open until #13446 is merged so we can try out the version placeholder. Reverting for now, and then will re-open after.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

Text/issue exemption: Pure revert PR.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request reverts the deprecation of the black and white parameters in Typography.material2021, removing the associated deprecation warnings, documentation, and tests. Feedback on the changes notes that the updated documentation introduces inaccuracies regarding platform-specific defaults for the black and white text themes, and suggests retaining the more detailed and accurate platform-dependent documentation.

[gemini-code-assist]

The reverted documentation states that macOS defaults to blackCupertino and whiteCupertino, and that other platforms (like Windows and Linux) default to blackMountainView and whiteMountainView. However, looking at Typography._withPlatform, macOS actually defaults to blackRedwoodCity/whiteRedwoodCity, Windows to blackRedmond/whiteRedmond, and Linux to blackHelsinki/whiteHelsinki.

Please keep the more accurate platform-dependent documentation that was introduced in the original PR, rather than reverting to this outdated and incorrect description.

  /// The default values for [black] and [white] depend on [platform]:
  /// [blackCupertino] and [whiteCupertino] on iOS, [blackRedwoodCity] and
  /// [whiteRedwoodCity] on macOS, [blackRedmond] and [whiteRedmond] on
  /// Windows, [blackHelsinki] and [whiteHelsinki] on Linux, and
  /// [blackMountainView] and [whiteMountainView] otherwise. If [platform] is
  /// null then both [black] and [white] must be specified.

[QuncCccccc]

LGTM!

[auto-submit]

autosubmit label was removed for flutter/packages/13463, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

[elliette]

Closing because #13434 landed before this did