[mackings]

If a VectorGraphic was removed while its picture was still loading, the picture was never disposed, so it leaked.

The fix caches the picture first, and lets a removed widget release it a moment later. That way, if another widget is waiting on the same load, it can still pick it up, and the picture only gets disposed when nobody is using it.

I didn't use the fix suggested in the issue because it disposes the picture too early when two widgets share a load, and the remaining one ends up drawing a disposed picture. There's a test for that case too.

Fixes flutter/flutter#190185

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request updates the vector_graphics package to version 1.2.5, addressing a memory leak that occurs when a VectorGraphic widget is removed before loading finishes. The fix ensures that loaded picture data is cached immediately and that its release is scheduled via a microtask if the widget is unmounted or the loader changes. Unit tests have been added to verify picture disposal behavior across multiple scenarios. As there are no review comments, no further feedback is provided.

[b-luk]

LGTM. Thanks, @mackings