Repository navigation
[google_fonts] Make the pendingFonts test deterministic - #13262
Merged
auto-submit[bot] merged 1 commit intoOct 15, 2026
Merged
Conversation
The test exercised the HTTP fetch path without faking PathProviderPlatform, so the package's background write to the application support directory failed with MissingPluginException after the test body had finished. Whether that late error was still attributed to the test was a matter of timing; on Windows CI it was, roughly 3 runs out of 10. Point the package at a temp directory the same way load_font_if_necessary_test.dart already does. Fixes flutter/flutter#194407
Contributor
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
okorohelijah
marked this pull request as ready for review
October 15, 2026 18:36
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates google_fonts_text_style_test.dart to run on the VM and configures a fake PathProviderPlatform using a temporary directory to prevent late-write errors. Feedback suggests registering a tear-down callback to delete the temporary directory and avoid leaking resources.
Piinks
approved these changes
Oct 15, 2026
Piinks
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you for this!
gmackall
pushed a commit
to gmackall/flutter
that referenced
this pull request
Oct 16, 2026
…r#194564) flutter/packages@da40eaf...93eede7 2026-10-16 41930132+hellohuanlin@users.noreply.github.com [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 okorohelijah@google.com [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 magder@google.com [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 victor.orozco@cloudsufi.com [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 okorohelijah@google.com [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 48776784+mackings@users.noreply.github.com [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 engine-flutter-autoroll@skia.org Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 37883572+edwin-hollen@users.noreply.github.com [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
suryaKommana2662
pushed a commit
to suryaKommana2662/flutter
that referenced
this pull request
Oct 29, 2026
…r#194564) flutter/packages@da40eaf...93eede7 2026-10-16 41930132+hellohuanlin@users.noreply.github.com [camera]fix a crash when switching camera while recording due to disconnected capturePhotoOputput (flutter/packages#13248) 2026-10-16 okorohelijah@google.com [various] Update iOS example apps to the 15.0 deployment target (flutter/packages#13223) 2026-10-16 36861262+QuncCccccc@users.noreply.github.com [material_ui] Add M3E `IconButton` example (flutter/packages#13085) 2026-10-15 magder@google.com [ci] Increase deprecation check minimum to iOS 16 (flutter/packages#13211) 2026-10-15 victor.orozco@cloudsufi.com [google_sign_in] Remove the public iOS handleOpen helper (flutter/packages#13273) 2026-10-15 okorohelijah@google.com [google_fonts] Make the pendingFonts test deterministic (flutter/packages#13262) 2026-10-15 48776784+mackings@users.noreply.github.com [vector_graphics_compiler] Fix tspan transform applied twice (flutter/packages#13129) 2026-10-15 engine-flutter-autoroll@skia.org Roll Flutter from 426be96 to 5c7e45a (21 revisions) (flutter/packages#13270) 2026-10-15 37883572+edwin-hollen@users.noreply.github.com [flutter_svg] Add golden widget tests for SVG alpha masks (flutter/packages#13245) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pendingFonts waits for fonts to be loadedfails on roughly 3 out of 10 runs ofWindows_x64 dart_unit_tests_shard_1, and only for PRs that make the tool run every package (.ci/,script/, Flutter rolls, ...), so it never shows up in postsubmit and blocks exactly the PRs that can't avoid it. The history and the analysis are in flutter/flutter#194407; the short version:expects in the test pass on every platform. The failure is a late error that flips an already-passed test to failed (the CI log shows the pass counter dropping from+92to+91 -1with no[E]block)._httpFetchFontAndSaveToDevicewrites the font to the application support directory without awaiting the result. The test does not fakePathProviderPlatform, so underflutter testthat write fails withMissingPluginExceptioninside the dropped future, after the test body has returned. This file has a single test, so whether the runner is still attached when the error lands is a timing question; Linux consistently loses the error, Windows regularly does not.expectreproduces the error on Linux every time.This change installs the same
FakePathProviderPlatformpointing at a temp directory thatload_font_if_necessary_test.dartalready uses, so the background write succeeds and there is no straggler error. With the change, the "wait two seconds" variant passes.Test-only change, so no version or CHANGELOG update (exempt category: PRs that only affect tests).
Fixes flutter/flutter#194407
Unblocks #13223
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2