Skip to content

[cupertino_icons] Migrate to cupertino_ui #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricardodalarme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cupertino_icons] Migrate to cupertino_ui #12649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion third_party/packages/cupertino_icons/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## NEXT

* Updates minimum supported SDK version to Flutter 3.38/Dart 3.10.
* Updates minimum supported SDK version to Flutter 3.44/Dart 3.12.
* Migrates to use `cupertino_ui` instead of `flutter/cupertino.dart`.

## 1.0.9

Expand Down
3 changes: 2 additions & 1 deletion third_party/packages/cupertino_icons/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+
version: 1.0.9

environment:
sdk: ^3.10.0
sdk: ^3.12.0
Comment thread
ricardodalarme marked this conversation as resolved.

dev_dependencies:
collection: ^1.18.0
cupertino_ui: ^1.0.0
flutter:
sdk: flutter
flutter_test:
Expand Down
2 changes: 1 addition & 1 deletion third_party/packages/cupertino_icons/test/cupertino_icons_golden_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import 'dart:io' show File, Platform;

import 'package:collection/collection.dart';
import 'package:flutter/cupertino.dart';
import 'package:cupertino_ui/cupertino_ui.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
Expand Down
7 changes: 3 additions & 4 deletions third_party/packages/cupertino_icons/test/cupertino_icons_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,16 @@
/// This test file is primarily here to serve as a source for code excerpts.
library;

import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:cupertino_ui/cupertino_ui.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
testWidgets('Cupertino Icon Test', (WidgetTester tester) async {
// #docregion CupertinoIcon
const icon = Icon(CupertinoIcons.heart_fill, color: Colors.pink, size: 24.0);
const icon = Icon(CupertinoIcons.heart_fill, color: CupertinoColors.systemPink, size: 24.0);
// #enddocregion CupertinoIcon

await tester.pumpWidget(const MaterialApp(home: Scaffold(body: icon)));
await tester.pumpWidget(const CupertinoApp(home: icon));

expect(find.byType(Icon), findsOne);
});
Expand Down
2 changes: 1 addition & 1 deletion third_party/packages/cupertino_icons/test/icons_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/cupertino.dart';
import 'package:cupertino_ui/cupertino_ui.dart';

int _compare(IconData a, IconData b) => a.codePoint.compareTo(b.codePoint);

Expand Down