Skip to content

Update skills_lint to published version ^0.5.1 #9984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reidbaker-agent wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −13
Open

Update skills_lint to published version ^0.5.1 #9984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
315cbaa
Update skills_lint to published version ^0.5.1
reidbaker Aug 28, 2026
e61044e
Add @visibleForTesting to NetworkRequest.durationDisplay to fix DCM
reidbaker Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/screens/network/network_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ abstract class NetworkRequest

String get id;

@visibleForTesting

@reidbaker reidbaker Aug 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated but was causing the tree to go red. Hoping that if it is fixed upstream that I dont have a conflict.

String get durationDisplay {
final duration = this.duration;
final text = duration != null
Expand Down
13 changes: 6 additions & 7 deletions pubspec.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,11 +752,10 @@ packages:
skills_lint:
dependency: transitive
description:
path: "packages/skills_lint"
ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3
resolved-ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3
url: "https://github.com/google/skills_lint.dart.git"
source: git
name: skills_lint
sha256: "5daeff89c8c9d812cfa811e119ae88a32bb81d28c73aa7e899155885b2e63a63"
url: "https://pub.dev"
source: hosted
version: "0.5.1"
sky_engine:
dependency: transitive
Expand Down Expand Up @@ -975,10 +974,10 @@ packages:
dependency: transitive
description:
name: vm_service
sha256: "0016aef94fc66495ac78af5859181e3f3bf2026bd8eecc72b9565601e19ab360"
sha256: "5f37239c4851efcef929cea7824e76df7f2f0970aef85d66bbc430afa40e72f0"
url: "https://pub.dev"
source: hosted
version: "15.2.0"
version: "15.3.0"
vm_service_protos:
dependency: transitive
description:
Expand Down
7 changes: 1 addition & 6 deletions tool/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,5 @@ dependencies:

dev_dependencies:
logging: ^1.1.1
# TODO(https://github.com/flutter/devtools/issues/9771): Update to published version
skills_lint:
git:
url: https://github.com/google/skills_lint.dart.git
path: packages/skills_lint
ref: e6e695e1550f81342fe5acd4dbe65040b5aa44c3
skills_lint: ^0.5.1
test: ^1.25.8
Loading