Check Dart formatting in all packages and in tool/

[srawlins]

No description provided.

[gemini-code-assist]

Code Review

This pull request adds formatting checks using dart format to several CI test scripts (package_tests.sh and tool_tests.sh) before running tests. The reviewer recommends invoking dart format directly instead of using the Flutter wrapper script $(dirname $(which flutter))/dart to avoid potential wrapper script issues and simplify the code, since the direct Dart SDK binary is already prioritized in the PATH.

[gemini-code-assist]

[CONCERN] Running $(dirname $(which flutter))/dart invokes the Dart wrapper script from flutter/bin, which can print "Waiting for another flutter command..." at inopportune times. As documented in setup.sh, the PATH is already configured to prioritize the direct Dart SDK binary. We should run dart format directly instead, which also makes the explanatory comment unnecessary.

Suggested change

	# Here, we use the dart instance from the flutter SDK.
	$(dirname $(which flutter))/dart format --output=none --set-exit-if-changed .
	dart format --output=none --set-exit-if-changed .

[kenzieschmoll]

please fix all of these - I agree the correct dart should already be on path

[gemini-code-assist]

[CONCERN] Running $(dirname $(which flutter))/dart invokes the Dart wrapper script from flutter/bin, which can print "Waiting for another flutter command..." at inopportune times. As documented in setup.sh, the PATH is already configured to prioritize the direct Dart SDK binary. We should run dart format directly instead, which also makes the explanatory comment unnecessary.

Suggested change

	# Here, we use the dart instance from the flutter SDK.
	$(dirname $(which flutter))/dart format --output=none --set-exit-if-changed .
	dart format --output=none --set-exit-if-changed .

[gemini-code-assist]

[CONCERN] Running $(dirname $(which flutter))/dart invokes the Dart wrapper script from flutter/bin, which can print "Waiting for another flutter command..." at inopportune times. As documented in setup.sh, the PATH is already configured to prioritize the direct Dart SDK binary. We should run dart format directly instead, which also makes the explanatory comment unnecessary.

Suggested change

	# Here, we use the dart instance from the flutter SDK.
	$(dirname $(which flutter))/dart format --output=none --set-exit-if-changed .
	dart format --output=none --set-exit-if-changed .

[gemini-code-assist]

[CONCERN] Running $(dirname $(which flutter))/dart invokes the Dart wrapper script from flutter/bin, which can print "Waiting for another flutter command..." at inopportune times. As documented in setup.sh, the PATH is already configured to prioritize the direct Dart SDK binary. We should run dart format directly instead, which also makes the explanatory comment unnecessary.

Suggested change

	# Here, we use the dart instance from the flutter SDK.
	$(dirname $(which flutter))/dart format --output=none --set-exit-if-changed .
	dart format --output=none --set-exit-if-changed .

[gemini-code-assist]

[CONCERN] Running $(dirname $(which flutter))/dart invokes the Dart wrapper script from flutter/bin, which can print "Waiting for another flutter command..." at inopportune times. As documented in setup.sh, the PATH is already configured to prioritize the direct Dart SDK binary. We should run dart format directly instead, which also makes the explanatory comment unnecessary.

Suggested change

	# Here, we use the dart instance from the flutter SDK.
	$(dirname $(which flutter))/dart format --output=none --set-exit-if-changed lib/ test/
	dart format --output=none --set-exit-if-changed lib/ test/

[kenzieschmoll]

hmm this seems like a bug? why aren't we running flutter test test/

[srawlins]

I'm not sure. I can fix it in a separate PR.

[kenzieschmoll]

a couple comments but generally lgtm