Skip to content

[tool] Update skills_lint to published version ^0.5.1 - #229

Open
reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker-agent:migrate-skills-lint-pub
Open

[tool] Update skills_lint to published version ^0.5.1#229
reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker-agent:migrate-skills-lint-pub

Conversation

@reidbaker-agent

Copy link
Copy Markdown
Contributor

Agent authored description

Updates the `tool/generator` dependency from a git-based dependency to the published `skills_lint: ^0.5.1` package on pub.dev.

Summary of Changes

  • Updated `tool/generator/pubspec.yaml` to depend on `skills_lint: ^0.5.1`.
  • Added missing `last_modified` metadata in `skills/dart-write-documentation/SKILL.md`.
  • Verified with `dart pub get`, `dart analyze --fatal-infos`, and `dart test` (all 100 tests passed cleanly).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the metadata of the Dart write-documentation skill file with a last modified date and simplifies the skills_lint dependency in tool/generator/pubspec.yaml by replacing the git reference with a version constraint (^0.5.1). There are no review comments, and I have no feedback to provide.

@github-actions

Copy link
Copy Markdown

⚠️ DO NOT modify these files!

The files within skills/dart-* are automatically synchronized from the upstream dart-lang/skills repository.

Please close this Pull Request and submit your changes to the upstream repository instead. Once merged upstream, your updates will be automatically brought over here.

---
name: dart-write-documentation
description: "Rules and formatting guidelines for writing Dart /// API documentation and doc comments. Use when documenting Dart code, writing doc comments for any Dart declaration (libraries, classes, methods, variables, etc.), or when instructed to follow the Effective Dart documentation guidelines."
metadata:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but this fails the last modified rule that is custom to this repo. It looks like the skills linter was either not run or bypassed in #224

@reidbaker
reidbaker requested a review from johnpryan August 28, 2026 21:54
@reidbaker
reidbaker marked this pull request as ready for review August 28, 2026 21:54
- Update tool/generator/pubspec.yaml to depend on published skills_lint: ^0.5.1
- Exempt synced dart-* skills from generator's LastModifiedRule
- Verify all 100 tests and static analysis pass cleanly
@reidbaker-agent
reidbaker-agent force-pushed the migrate-skills-lint-pub branch from ef1c6c5 to 19539f7 Compare August 28, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants