[flutter_webrtc_tizen]Upgrade flutter webrtc to 1.4.1 by xiaowei-guan · Pull Request #993 · flutter-tizen/plugins

xiaowei-guan · 2026-04-15T10:07:07Z

Upgrade flutter webrtc to 1.4.1

gemini-code-assist

Code Review

This pull request updates the flutter_webrtc dependency to version 1.3.1 and introduces a TaskRunner interface to facilitate thread-safe event dispatching. New features include setVolume for audio tracks, dataChannelGetBufferedAmount, and configurable RTC logging severity. The refactor propagates the TaskRunner through various observers and managers and updates several WebRTC internal headers. Feedback identifies critical issues including a use-after-free vulnerability in setVolume, the lack of initialization for the task_runner_ member, and a dangling pointer risk with a static global logging proxy. Further improvements are requested regarding the robustness of the maybeFindDouble helper, adherence to C++ casting standards, and the restoration of a check for defined statistics members.

- Update minimum Flutter and Dart version to 3.13 and 3.1 - Fix analyze issue - Update code format - Adds compatibility with `http` 1.0 in example

gemini-code-assist

Code Review

This pull request updates the flutter_webrtc_tizen plugin to version 0.2.0, increasing the minimum SDK requirements and updating the flutter_webrtc dependency. Key additions include a TaskRunner for thread-safe event dispatching, UTF-8 sanitization for device identifiers, and support for data packet encryption and frame capturing. The implementation also introduces audio volume control, buffered amount retrieval for data channels, and enhanced logging capabilities. Review feedback identifies critical issues in the frame capture logic, specifically a busy-wait loop that blocks the main thread and a memory leak in pixel buffer allocation. Additionally, concerns were raised regarding thread safety for shared flags, the use of volatile for synchronization, and potential crashes due to dangling pointers in the global logging callback.

gemini-code-assist · 2026-04-24T11:33:18Z

+  while (!catch_frame_) {
+  }


This busy wait loop blocks the platform thread (main thread) until a frame is captured. This will cause the application UI to freeze and may trigger an ANR (Application Not Responding) if the frame capture takes too long or fails. Please use std::condition_variable with a timeout to wait for the frame asynchronously or at least non-blockingly.

gemini-code-assist · 2026-04-24T11:33:18Z

+  int width = frame_.get()->width();
+  int height = frame_.get()->height();
+  int bytes_per_pixel = 4;
+  uint8_t* pixels = new uint8_t[width * height * bytes_per_pixel];


The pixels buffer is allocated on the heap but never deleted, leading to a memory leak every time a frame is saved. Use std::vector<uint8_t> or std::unique_ptr<uint8_t[]> to manage the memory automatically.

Suggested change

uint8_t* pixels = new uint8_t[width * height * bytes_per_pixel];

std::vector<uint8_t> pixels(width * height * bytes_per_pixel);

frame_.get()->ConvertToARGB(RTCVideoFrame::Type::kABGR, pixels.data(),

/* unused */ -1, width, height);

FILE* file = fopen(path_.c_str(), "wb");

if (!file) {

return false;

}

svpng(file, width, height, pixels.data(), 1);

gemini-code-assist · 2026-04-24T11:33:19Z


 namespace flutter_webrtc_plugin {

+static EventChannelProxy* eventChannelProxy = nullptr;


The static global eventChannelProxy is a raw pointer to an object owned by a FlutterWebRTC instance. If the instance is destroyed, the pointer becomes dangling, and the logger callback (which is global to the process) will crash when it attempts to use it. Please ensure the log sink is removed and the pointer is cleared in the FlutterWebRTC destructor.

gemini-code-assist · 2026-04-24T11:33:19Z

+      FlutterFrameCryptor::FlutterFrameCryptor(this),
+      FlutterDataPacketCryptor::FlutterDataPacketCryptor(this) {}

 FlutterWebRTC::~FlutterWebRTC() {}


The destructor should clean up the global logger sink to prevent crashes if log messages are received after the plugin instance is destroyed.

FlutterWebRTC::~FlutterWebRTC() { libwebrtc::LibWebRTCLogging::removeLogSink(); eventChannelProxy = nullptr; }

gemini-code-assist · 2026-04-24T11:33:19Z

 * Fix analyze issue.
 * Update code format.
 * Adds compatibility with `http` 1.0 in example.
+* Update flutter_webrtc to 1.3.1.


There is a discrepancy between the version mentioned here (1.3.1) and the version mentioned in the PR title and example pubspecs (1.4.1). Please ensure the version is consistent across all files.

Suggested change

* Update flutter_webrtc to 1.3.1.

* Update flutter_webrtc to 1.4.1.

gemini-code-assist · 2026-04-24T11:33:19Z


 #include <list>
 #include <memory>
+#include <mutex>


Please include <atomic> to support thread-safe flag management in EventChannelProxyImpl and other classes.

Suggested change

#include <mutex>

#include <atomic>

#include <mutex>

gemini-code-assist · 2026-04-24T11:33:19Z

-  std::unique_ptr<EventSink> sink_;
+  std::shared_ptr<flutter::EventSink<flutter::EncodableValue>> sink_;
  std::list<EncodableValue> event_queue_;
  bool on_listen_called_ = false;


The on_listen_called_ flag is accessed from multiple threads (platform thread for callbacks and potentially other threads for Success). It should be atomic to avoid race conditions.

Suggested change

bool on_listen_called_ = false;

std::atomic<bool> on_listen_called_ = false;

gemini-code-assist · 2026-04-24T11:33:19Z

+  std::string path_;
+  std::mutex mutex_;
+  scoped_refptr<RTCVideoFrame> frame_;
+  volatile bool catch_frame_;


In C++, volatile does not provide atomicity or memory ordering guarantees for thread synchronization. Use std::atomic<bool> instead, or use a condition variable for more efficient synchronization.

Suggested change

volatile bool catch_frame_;

std::atomic<bool> catch_frame_;

gemini-code-assist · 2026-04-24T11:33:19Z

+    return;
+  }
+
+  auto keyProvider = base_->key_providers_[keyProviderId];


Using operator[] on a std::map will insert a default-constructed entry if the key is not found. This pollutes the map with null entries for invalid IDs. It is better to use find() to check for existence.

auto it = base_->key_providers_.find(keyProviderId); if (it == base_->key_providers_.end()) { result->Error("createDataPacketCryptor", "createDataPacketCryptor() keyProvider is null"); return; } auto keyProvider = it->second;

gemini-code-assist · 2026-04-24T11:33:19Z

-    if (!member->IsDefined()) {
-      continue;
-    }
    switch (member->GetType()) {


The check if (!member->IsDefined()) was removed. Accessing values of undefined stats members can lead to unexpected behavior or garbage data. It is recommended to restore this check to ensure only defined stats are included in the report.

Suggested change

switch (member->GetType()) {

if (!member->IsDefined()) {

continue;

}

switch (member->GetType()) {

1.Fixed the use-after-free vulnerability caused by assigning `scoped_refptr<RTCMediaTrack>` returned by `MediaTrackForId()` to raw pointers. The temporary `scoped_refptr` was being destroyed at the end of the assignment statement, potentially deleting the track object before it could be used.

change so file Flags to soft

Merge flutter-webrtc 1.3.0 code

efcf27b

github-actions Bot added the p: flutter_webrtc label Apr 15, 2026

xiaowei-guan marked this pull request as draft April 15, 2026 10:07

gemini-code-assist Bot reviewed Apr 15, 2026

View reviewed changes

xiaowei-guan added 5 commits April 16, 2026 02:07

Update libwebrtc lib files

74cb2cf

Fix analyze issue

94edd72

Implement Tizen TaskRunner

a5bb086

Update tizen task runner

39d451b

Bump version to 0.2.0

7558aa8

- Update minimum Flutter and Dart version to 3.13 and 3.1 - Fix analyze issue - Update code format - Adds compatibility with `http` 1.0 in example

xiaowei-guan changed the title ~~Upgrade flutter webrtc to 1.3.1~~ Upgrade flutter webrtc to 1.4.1 Apr 24, 2026

xiaowei-guan marked this pull request as ready for review April 24, 2026 11:30

xiaowei-guan requested review from JSUYA, gin7773 and seungsoo47 April 24, 2026 11:31

gemini-code-assist Bot reviewed Apr 24, 2026

View reviewed changes

xiaowei-guan changed the title ~~Upgrade flutter webrtc to 1.4.1~~ [flutter webrtc tizen]Upgrade flutter webrtc to 1.4.1 Apr 24, 2026

xiaowei-guan changed the title ~~[flutter webrtc tizen]Upgrade flutter webrtc to 1.4.1~~ [flutter_webrtc_tizen]Upgrade flutter webrtc to 1.4.1 Apr 24, 2026

xiaowei-guan and others added 8 commits April 24, 2026 23:17

Upgrade to m144

8e96aac

code format

cdb26b3

Fix code review issue

8ab0060

Fix coredump issue

465b318

change so file Flags to soft

Update readme

8bb9e37

Update example webrtc version

04bd337

Merge branch 'master' into upgrade_webrtc

e37912b

-  uint8_t* pixels = new uint8_t[width * height * bytes_per_pixel];
+  std::vector<uint8_t> pixels(width * height * bytes_per_pixel);
+  frame_.get()->ConvertToARGB(RTCVideoFrame::Type::kABGR, pixels.data(),
+                              /* unused */ -1, width, height);
+  FILE* file = fopen(path_.c_str(), "wb");
+  if (!file) {
+    return false;
+  }
+  svpng(file, width, height, pixels.data(), 1);


		namespace flutter_webrtc_plugin {

		static EventChannelProxy* eventChannelProxy = nullptr;

	* Update flutter_webrtc to 1.3.1.
	* Update flutter_webrtc to 1.4.1.

	bool on_listen_called_ = false;
	std::atomic<bool> on_listen_called_ = false;

Conversation

xiaowei-guan commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

xiaowei-guan commented Apr 15, 2026 •

edited

Loading