[video_player_avplay] Fixed an issue where subtitles for content with pre-roll/insesrted ads in DASH could not be rendered.#1007
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the caption selection logic in video_player.dart to include start-time checks for both text and picture captions. A logic error was identified in the picture caption implementation where the greater-than operator was used instead of the less-than operator for the start time check, which would cause captions to be hidden incorrectly during their display window.
There was a problem hiding this comment.
Code Review
This pull request updates the video_player_avplay package to version 0.8.8 and modifies the _currentCaptions getter to prevent subtitle rendering when the playback position is before the caption start time. Feedback identifies critical safety issues where the new conditional checks could cause runtime crashes due to null or empty list access, and notes that similar logic in other methods remains inconsistent. Additionally, a typo was found in the changelog.
2 participants
No description provided.