test(efc): initialize runtime type in runtime info helper#5953
Conversation
|
Hi @NO1SETTER. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the newEFCEngineRT test helper function in pkg/ddc/efc/runtime_info_test.go to initialize the runtimeType field with common.EFCRuntime. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
LGTM! Good catch -- initializing runtimeType in the test helper ensures the test accurately reflects the real runtime setup. Small but meaningful improvement to test correctness.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhouyuxiang <ebata20000508@163.com>
NO1SETTER
force-pushed
the
bg-lab1-652022330038
branch
from
ae61353 to
72b1802
Compare
|
New changes are detected. LGTM label has been removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5953 +/- ##
==========================================
+ Coverage 62.59% 64.86% +2.26%
==========================================
Files 480 480
Lines 32801 33514 +713
==========================================
+ Hits 20533 21738 +1205
+ Misses 10633 10051 -582
- Partials 1635 1725 +90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
2 participants
What is changed
Initialize
runtimeTypeinnewEFCEngineRTtest helper.Why
In production code,
EFCEngineis initialized with a runtime type.The test helper previously did not set this field, which made the test object inconsistent with the real engine initialization path.
This change aligns the test helper with the production behavior and makes the runtime info related test setup more accurate.
Verification
GO111MODULE=on GOWORK=off GOFLAGS=-mod=vendor GOCACHE=/private/tmp/fluid-gocache go test ./pkg/ddc/efc -run TestEFCEngine_getRuntimeInfo -count=1okRelated issue
Related to #5952