chore(deps): bump golangci/golangci-lint-action from 6.5.2 to 9.2.1#5910
chore(deps): bump golangci/golangci-lint-action from 6.5.2 to 9.2.1#5910dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
dependencies
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
Reviewed the diff: golangci/golangci-lint-action SHA pin update (v6.5.2 -> v9.2.1) in project-check.yml. This is a significant 3-major-version jump (6->9). The current usage (version: latest, args: --timeout 10m --verbose) is basic and likely compatible, but such a large jump warrants maintainer verification that v9's API/defaults haven't introduced breaking behavior. Additionally, the old v6.5.2 uses Node.js 20 which is being deprecated on GitHub Actions (June 16, 2026), so upgrading is advisable. Recommend maintainer confirm v9 compatibility before merging.
|
@dependabot rebase |
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6.5.2 to 9.2.1. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@55c2c14...82606bf) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-version: 9.2.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/github_actions/golangci/golangci-lint-action-9.2.1
branch
from
849a8fb to
d72b4e5
Compare
- Fix govet: use %s format string for Eventf in juicefs/transform.go - Fix errcheck: explicitly ignore file.Close error in metadata.go - Add .golangci.yml to suppress QF/ST1023 style checks and errcheck in test files (common Go test patterns)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5910 +/- ##
=======================================
Coverage 63.56% 63.56%
=======================================
Files 479 479
Lines 33275 33275
=======================================
Hits 21150 21150
Misses 10445 10445
Partials 1680 1680 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cheyang
left a comment
cheyang
left a comment
There was a problem hiding this comment.
Re-review (sha bc6f664)
Thanks for the follow-up commit fixing govet and errcheck issues. However, the lint CI is still failing with ~40 errors (errcheck in test files, QF1008, QF1011, ST1023, etc.).
Root causes
-
Wrong config key for v2 format -
.golangci.ymlusesissues.exclude-ruleswhich is the golangci-lint v1 config syntax. Inversion: "2"config, the correct key isissues.exclusions.rules(nested underlinters.exclusions). The errcheck exclusion for_test.gofiles is silently ignored. -
Missing
working-directory- The checkout uses a customGOPATHlayout ($GOPATH/src/github.com/fluid-cloudnative/fluid), but the lint action does not specifyworking-directory, so golangci-lint may not pick up.golangci.ymlfrom the checkout path at all. -
Incomplete staticcheck suppressions - QF1008 appears in production code (not just tests), yet the config only disables it globally in the staticcheck settings section. Since that section is also not being read correctly (points 1-2 above), none of the suppressions take effect.
Relationship to PR #5977
PR #5977 addresses all three issues above with the correct v2 config structure and adds working-directory to the action step. That PR explicitly notes it supersedes this one.
Recommendation
This PR should be closed in favor of #5977, which provides a complete and working solution for the same upgrade. If you'd prefer to keep this PR alive, the .golangci.yml needs to be rewritten with the correct v2 schema and the action step needs working-directory.
Verdict: needs-work (lint CI failing, superseded by #5977)
|
This PR bumps Verdict: pending — recommend closing in favor of #5977 |
…5977) * chore: bump golangci-lint-action to v9.2.1 and fix v2 config format - Bump golangci/golangci-lint-action from v6.5.2 to v9.2.1 - Add .golangci.yml with version 2 config format, using the correct `issues.exclusions.rules` key (not the v1 `issues.exclude-rules`) - Fix printf format string in juicefs transform.go (go vet) - Fix unchecked file.Close in metadata.go (errcheck) Supersedes #5910. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: add working-directory to golangci-lint-action The `defaults.run.working-directory` only applies to `run:` steps, not `uses:` action steps. The golangci-lint-action was running in the default working directory and could not find `.golangci.yml` in the custom checkout path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: move exclusions to top-level in golangci-lint v2 config In golangci-lint v2 config format, `exclusions` is a top-level key, not nested under `issues`. The previous config caused schema validation failure: "additional properties 'exclusions' not allowed" under issues. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: place exclusions under linters in golangci-lint v2 config In golangci-lint v2, `exclusions` is a child of `linters`, not a top-level key or under `issues`. Move it to `linters.exclusions.rules`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: suppress ST1000 and ST1003 staticcheck rules These are pre-existing naming convention and package comment style issues throughout the codebase. Suppressing them avoids a large-scale refactor unrelated to the golangci-lint upgrade. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: suppress ST1016 and ST1020 staticcheck rules Pre-existing receiver naming inconsistencies (ST1016) and exported method comment format issues (ST1020) throughout the codebase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> * fix: disable all ST and QF staticcheck categories Use wildcards to suppress all style (ST*) and quickfix (QF*) checks rather than adding individual rules one by one. These are pre-existing conventions throughout the codebase and not actionable bugs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
|
Looks like golangci/golangci-lint-action is up-to-date now, so this is no longer needed. |
dependabot
Bot
deleted the
dependabot/github_actions/golangci/golangci-lint-action-9.2.1
branch
|
Bumps golangci/golangci-lint-action from 6.5.2 to 9.2.1.
Release notes
Sourced from golangci/golangci-lint-action's releases.
... (truncated)
Commits
82606bfchore: prepare release v9.2.197c8387chore: improve workflows (#1394)28d0a19build(deps): bump the dependencies group across 1 directory with 2 updates633fbc7build(deps): bump github/codeql-action from 4.35.3 to 4.35.4 (#1391)59f43e2build(deps): bump github/codeql-action from 4.35.2 to 4.35.3 (#1389)9eb174ebuild(deps): bump fast-xml-builder from 1.1.5 to 1.2.0 (#1386)4f52504build(deps): bump github/codeql-action from 4 to 4.35.2 (#1384)6f87dfddocs: update examplesc9500d7chore: improve workflows03b1faachore: improve issue templates