out_prometheus_exporter: apply HTTP server options#12111
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe Prometheus exporter now forwards configured HTTP server buffer and worker settings. A non-Windows runtime test starts the exporter and verifies the resulting server configuration and runtime initialization. ChangesPrometheus HTTP options
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c43d302a7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Propagate buffer_chunk_size and workers from the parsed HTTP server configuration when creating the exporter HTTP server. Signed-off-by: Stefano Tondo <stondo@gmail.com>
Verify that the configured buffer chunk size and worker count reach the embedded HTTP server and create a worker runtime. Signed-off-by: Stefano Tondo <stondo@gmail.com>
4c43d30 to
23f280e
Compare
Summary
Propagate
buffer_chunk_sizeandworkersfrom the parsed HTTP server configurationwhen
out_prometheus_exportercreates its embedded HTTP server.The plugin already applies
idle_timeout,buffer_max_size, andmax_connections.Omitting the other two parsed options makes valid configuration ineffective,
particularly
http_server.workers.Fixes #12110
Changes
http_server.buffer_chunk_sizehttp_server.workersThe test uses the actual Fluent Bit engine and verifies that:
It fails before the fix and passes afterward.
Compatibility
The default behavior is unchanged. The patch only makes explicitly configured HTTP
server options effective.
The same partial option propagation appears in
out_vivo_exporter; this PR remainsscoped to the reproduced Prometheus exporter defect.
Testing
Example configuration:
Commands:
These ran in the documented Debian 12 rootless Podman environment. The explicit AVX2
flag is a GCC 12 compatibility workaround for bundled
simdutf, not part of thischange.
Results:
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Packaging
Documentation
Backporting
5.0backport after the master change is acceptedFluent Bit is licensed under Apache 2.0. By submitting this pull request I understand
that this code will be released under the terms of that license.
Summary by CodeRabbit