Skip to content

oauth2: adding new client_secret_file parameter to http and opentelemetry#2629

Open
fernandoalexandre wants to merge 2 commits into
fluent:masterfrom
fernandoalexandre:feature/oauth2-client-secret-file
Open

oauth2: adding new client_secret_file parameter to http and opentelemetry#2629
fernandoalexandre wants to merge 2 commits into
fluent:masterfrom
fernandoalexandre:feature/oauth2-client-secret-file

Conversation

@fernandoalexandre

@fernandoalexandre fernandoalexandre commented Jul 20, 2026

Copy link
Copy Markdown

Add oauth2.client_secret_file to http and opentelemetry property tables.

Related to: fluent/fluent-bit#12118

Summary by CodeRabbit

  • Documentation
    • Added documentation for the optional oauth2.client_secret_file setting for Fluent Bit pipeline outputs.
    • Clarified that oauth2.client_secret_file overrides oauth2.client_secret when provided.
    • Updated HTTP and OpenTelemetry output plugin configuration details to include this new OAuth 2.0 option.

@fernandoalexandre
fernandoalexandre requested review from a team and eschabell as code owners July 20, 2026 15:56
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1b778fb3-feb1-4197-bec5-785c8d5c1056

📥 Commits

Reviewing files that changed from the base of the PR and between 8a7669d and 2c6ed22.

📒 Files selected for processing (3)
  • administration/configuring-fluent-bit/yaml/pipeline-section.md
  • pipeline/outputs/http.md
  • pipeline/outputs/opentelemetry.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • pipeline/outputs/http.md

📝 Walkthrough

Walkthrough

Documents the oauth2.client_secret_file setting in shared pipeline YAML, HTTP output, and OpenTelemetry output configuration tables, including that it overrides oauth2.client_secret.

Changes

OAuth 2.0 output documentation

Layer / File(s) Summary
Document client secret file setting
administration/configuring-fluent-bit/yaml/pipeline-section.md, pipeline/outputs/http.md, pipeline/outputs/opentelemetry.md
Adds the optional oauth2.client_secret_file setting and documents its precedence over oauth2.client_secret.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: 5.0

Suggested reviewers: eschabell

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding the oauth2 client_secret_file parameter to the HTTP and OpenTelemetry docs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Fernando Alexandre <fernandoalexandre@users.noreply.github.com>
@fernandoalexandre
fernandoalexandre force-pushed the feature/oauth2-client-secret-file branch from d768dce to 8a7669d Compare July 21, 2026 08:18
@eschabell eschabell self-assigned this Jul 21, 2026
@eschabell eschabell added waiting-on-code-merge waiting-on-review Waiting on a review from mainteners labels Jul 21, 2026
Add the `oauth2.client_secret_file` parameter to the OAuth 2.0 tables in the
HTTP and OpenTelemetry output plugins, and to the shared OAuth 2.0 parameter
table in the YAML pipeline section. The parameter takes a path to a file
containing the client secret and overrides `oauth2.client_secret` when both
are set.

Signed-off-by: Fernando Alexandre <fernandoalexandre@users.noreply.github.com>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell
eschabell force-pushed the feature/oauth2-client-secret-file branch from 8a7669d to 2c6ed22 Compare July 21, 2026 11:45

@eschabell eschabell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fernandoalexandre fixed a few vale issue and pushed the changes, now ready to merge once the code PR merges. Thanks for the docs PR!

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants