core: unlink objects before destruction#29
Merged
Conversation
Signed-off-by: Eduardo Silva <eduardo@chronosphere.io>
edsiper
force-pushed
the
agent/fix-logical-bugs
branch
from
July 13, 2026 19:38
b50c5c9 to
7eed26c
Compare
edsiper
marked this pull request as ready for review
July 13, 2026 19:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Most child constructors immediately attach their objects to a parent
cfl_list, but their public destroy functions freed the object without removing its list node. Direct destruction therefore left a dangling parent entry. Traversing or destroying the parent later could dereference freed memory or free the object again. The existing attribute-unit destructor already had the required orphan check, but the other list-owned types did not.The regression reproduced the original behavior as
free(): double free detected in tcache 2.Impact
Callers can safely destroy linked samples, sample types, mappings, locations and lines, functions, links, profiles, scope profiles, and resource profiles independently. Parent cleanup still works for already-unlinked objects. Public structure layouts and encoded formats are unchanged.
Validation
git diff --cached --checkA Clang sanitizer run was also attempted, but the pre-existing
profiletest hung under that local runtime. The non-sanitized Clang run and GCC sanitizer run both completed successfully.