Skip to content

fix timerEntity.getRepeat() in TimerJobEntityManagerImpl may return null, which causes a NullPointerException when calling split() - #4238

Open
panshaobin wants to merge 1 commit into
flowable:mainfrom
panshaobin:main.2
Open

fix timerEntity.getRepeat() in TimerJobEntityManagerImpl may return null, which causes a NullPointerException when calling split()#4238
panshaobin wants to merge 1 commit into
flowable:mainfrom
panshaobin:main.2

Conversation

@panshaobin

Copy link
Copy Markdown
Contributor

fix(flowable-job):timerEntity.getRepeat() in TimerJobEntityManagerImpl may return null, which causes a NullPointerException when calling split()

…l may return null, which causes a NullPointerException when calling split()

@filiphr filiphr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @panshaobin. Can you please add a test case for this? I do not think that this can ever happen since at this point the timerEntity.getRepeat() will not be null, because this gets called from:

if (timerJob.getRepeat() != null) {
TimerJobEntityManager timerJobEntityManager = jobServiceConfiguration.getTimerJobEntityManager();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants