Skip to content

fix(flowable-rest):Resource Leakage Issue in Flowable-Rest Module #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panshaobin wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix(flowable-rest):Resource Leakage Issue in Flowable-Rest Module #4237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...ain/java/org/flowable/rest/service/api/runtime/process/BaseExecutionVariableResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ protected byte[] getVariableDataByteArray(Execution execution, String variableNa
response.setContentType("application/octet-stream");

} else if (RestResponseFactory.SERIALIZABLE_VARIABLE_TYPE.equals(variable.getType())) {
ByteArrayOutputStream buffer = new ByteArrayOutputStream();
ObjectOutputStream outputStream = new ObjectOutputStream(buffer);
outputStream.writeObject(variable.getValue());
outputStream.close();
result = buffer.toByteArray();
response.setContentType("application/x-java-serialized-object");
try (ByteArrayOutputStream buffer = new ByteArrayOutputStream();
ObjectOutputStream outputStream = new ObjectOutputStream(buffer)) {
outputStream.writeObject(variable.getValue());
result = buffer.toByteArray();
response.setContentType("application/x-java-serialized-object");
}

} else {
throw new FlowableObjectNotFoundException("The variable does not have a binary data stream.", null);
Expand Down