refactor(flow-php/etl): remove union columns - #2657
Merged
Merged
Conversation
- drop UnionDefinition, union_schema() and their helpers - null|T inside list/map/structure types becomes ?T, other unions are refused - postgresql array columns are list<?T>, writable to Floe and Parquet - json schema anyOf nested in items/properties is refused - pin just, md-link-linter image and azurite in CI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2657 +/- ##
============================================
- Coverage 88.58% 88.54% -0.04%
- Complexity 0 26465 +26465
============================================
Files 2046 2042 -4
Lines 78197 77954 -243
============================================
- Hits 69272 69028 -244
- Misses 8925 8926 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
Fixed
flow-php/etl-adapter-postgresql- array columns are typedlist<?T>and can be written to Floe and ParquetChanged
flow-php/etl-null|Tinside list, map and structure column types becomes?Tflow-php/etl- any other union inside a column type throwsUnsupportedUnionTypeExceptionflow-php/etl-adapter-json- JSON SchemaanyOfnested in items or properties is refusedRemoved
flow-php/etl-UnionDefinitionandunion_schema()Deprecated
Security