perf: ISO temporal fast paths and file constants after hydration - #2656
Merged
Merged
Conversation
- schema inference narrows ISO dates/datetimes without date_parse() - ISO date cast fast path in DateType/DateTimeType and native cast - ISO regexes tightened to timelib field ranges - extractors stamp file constants after hydration via fillRows() - shared date_check/uuid_check modules in the extension - ordered_on date column in the benchmark Orders fixture
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2656 +/- ##
=========================================
Coverage 88.59% 88.59%
Complexity 26576 26576
=========================================
Files 2046 2046
Lines 78181 78197 +16
=========================================
+ Hits 69263 69279 +16
Misses 8918 8918 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/types- public ISO gatesStringTemporalParts::isoDateTime()/isoDate()andDateType::ISO_DATEFixed
Changed
flow-php/types- ISO dates and datetimes narrowed withoutdate_parse()flow-php/types- ISO date fast path inDateTypeandDateTimeTypecastsflow-php/types-DateTimeType::ISO_DATE_TIMEpublic and limited to timelib field rangesflow-php/flow-php-ext- native CSV narrowing and date casts use byte-level ISO gatesflow-php/etl-adapter-csv- file constants stamped after hydration viafillRows()flow-php/etl-adapter-json- file constants stamped after hydration viafillRows()flow-php/etl-adapter-text- file constants stamped after hydration viafillRows()flow-php/etl-adapter-xml- file constants stamped after hydration viafillRows()flow-php/etl-adapter-excel- file constants stamped after hydration viafillRows()flow-php/etl-adapter-parquet- file constants stamped after hydration viafillRows()Removed
Deprecated
Security