Skip to content

fix(flow-php/symfony-telemetry-bundle): read the security token without marking the session as used - #2637

Merged
norberttech merged 1 commit into
1.xfrom
2636-bug-securityspansubscriber-makes-every-response-uncacheable-when-the-firewall-is-lazy
Sep 18, 2026
Merged

norberttech merged 1 commit into
1.xfrom
2636-bug-securityspansubscriber-makes-every-response-uncacheable-when-the-firewall-is-lazy

Conversation

@norberttech

Copy link
Copy Markdown
Member

Resolves: #2636

Change Log


Added

Fixed

  • flow-php/symfony-telemetry-bundle - security instrumentation no longer marks the session as used, which made every response private behind a lazy firewall

Changed

  • flow-php/symfony-telemetry-bundle - the security token is read from security.untracked_token_storage, and only when the request carries a span

Removed

Deprecated

Security

…ut marking the session as used

- inject security.untracked_token_storage
- skip the token read when the request carries no span
- cover the lazy firewall Cache-Control regression
@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.55%. Comparing base (07ad8f6) to head (886ff18).
⚠️ Report is 1 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x    #2637   +/-   ##
=========================================
  Coverage     84.54%   84.55%           
- Complexity    30064    30065    +1     
=========================================
  Files          2007     2007           
  Lines         87050    87052    +2     
=========================================
+ Hits          73593    73603   +10     
+ Misses        13457    13449    -8     
Components Coverage Δ
etl 91.48% <ø> (-0.01%) ⬇️
cli 75.45% <ø> (ø)
lib-array-dot 96.52% <ø> (ø)
lib-azure-sdk 64.44% <ø> (ø)
lib-doctrine-dbal-bulk 70.36% <ø> (ø)
lib-filesystem 77.08% <ø> (ø)
lib-types 90.49% <ø> (ø)
lib-parquet 70.32% <ø> (+0.09%) ⬆️
lib-parquet-viewer 82.26% <ø> (ø)
lib-snappy 89.86% <ø> (ø)
lib-dremel 0.00% <ø> (ø)
lib-postgresql 85.63% <ø> (ø)
lib-telemetry 86.62% <ø> (ø)
bridge-filesystem-async-aws 86.31% <ø> (ø)
bridge-filesystem-azure 80.96% <ø> (ø)
bridge-filesystem-sftp 91.02% <ø> (ø)
bridge-monolog-http 91.54% <ø> (ø)
bridge-monolog-telemetry 94.79% <ø> (ø)
bridge-openapi-specification 60.86% <ø> (ø)
symfony-http-foundation 56.86% <ø> (ø)
bridge-psr18-telemetry 100.00% <ø> (ø)
bridge-psr3-telemetry 98.95% <ø> (ø)
bridge-psr7-telemetry 100.00% <ø> (ø)
bridge-telemetry-otlp 90.11% <ø> (ø)
bridge-symfony-http-foundation-telemetry 92.85% <ø> (ø)
bridge-symfony-filesystem-bundle 91.85% <ø> (ø)
bridge-symfony-filesystem-cache 98.18% <ø> (ø)
bridge-symfony-postgresql-bundle 93.04% <ø> (ø)
bridge-symfony-postgresql-cache 94.41% <ø> (ø)
bridge-symfony-postgresql-messenger 98.80% <ø> (ø)
bridge-symfony-postgresql-session 93.65% <ø> (ø)
bridge-symfony-telemetry-bundle 90.72% <85.71%> (+<0.01%) ⬆️
adapter-chartjs 80.50% <ø> (ø)
adapter-csv 95.98% <ø> (ø)
adapter-doctrine 93.02% <ø> (ø)
adapter-google-sheet 80.11% <ø> (ø)
adapter-http 76.52% <ø> (ø)
adapter-json 65.62% <ø> (ø)
adapter-logger 28.57% <ø> (ø)
adapter-parquet 75.38% <ø> (ø)
adapter-text 70.78% <ø> (ø)
adapter-xml 59.83% <ø> (ø)
adapter-avro 0.00% <ø> (ø)
adapter-excel 79.10% <ø> (ø)
adapter-postgresql 79.96% <ø> (ø)
adapter-seal 65.69% <ø> (ø)
bridge-phpunit-postgresql 75.30% <ø> (ø)
bridge-phpunit-telemetry 87.36% <ø> (ø)
bridge-phpstan-types 0.00% <ø> (ø)
bridge-postgresql-valinor 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech
norberttech merged commit 54647d0 into 1.x Sep 18, 2026
50 checks passed
@norberttech
norberttech deleted the 2636-bug-securityspansubscriber-makes-every-response-uncacheable-when-the-firewall-is-lazy branch September 18, 2026 19:29
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: SecuritySpanSubscriber makes every response uncacheable when the firewall is lazy

1 participant