fix(flow-php/etl): rename_map() breaks on numeric entry names - #2635
Merged
Merged
Conversation
- cast numeric entry name back to string for Schema::rename() - keep strategy chaining keyed by the original name - type name-keyed row storage as array-key, cast to string at name boundaries - pin codecov-action comment to the tag it resolves to
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2635 +/- ##
============================================
+ Coverage 84.54% 84.55% +0.01%
- Complexity 23268 30064 +6796
============================================
Files 2007 2007
Lines 87047 87050 +3
============================================
+ Hits 73590 73604 +14
+ Misses 13457 13446 -11 🚀 New features to boost your workflow:
|
- drop the per-comparison strval() from the sort/dedup path - pin both the key coercion and its inverse in the extension phpt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
flow-php/etl-renameEach(rename_map(...))no longer throws a TypeError on numeric entry names.flow-php/etl- chained rename strategies no longer desync rows from the schema on numeric entry names.Changed
flow-php/etl- name-keyed row storage is typed asarray-keyand names are cast back to string at consuming boundaries.flow-php/etl-adapter-csv- inferred column names are cast to string before schema divergence checks.flow-php/etl-adapter-parquet- encoder row type widened toarray-key.flow-php/parquet- reader and writer row types widened toarray-key.Removed
flow-php/etl-@mago-ignoresuppressions that existed only to hide the unrepresentable row value type.Deprecated
Security